[Logs UI] Set streamLive false in URL state when arriving from link-to

[Zacqary]

Summary

Closes #55652

Removes the streamLive param from the log position URL state whenever it's false, and only adds it back in when it's true.

Forces the streamLive param to false when replacing a link-to search string in the logs stream URL.

This fixes a flaky test.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• [ ] This was checked for cross-browser compatibility, including a check against IE11
• [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• [ ] Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-test-triage (failed-test)

[elasticmachine]

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

[Zacqary]

@elasticmachine merge upstream

[afgomez]

I'm thinking out loud.

I understand the reason why this test was flaky was because the streamLive parameter in the URL sometimes was false, and sometimes wasn't there, and the test was only covering the false case.

streamLive is a 3-state boolean (true, false, and not-there). In practice false and not-there have the same effect so we can remove one of them.

This PR removes false leaving only two states: true and not-there. I think that makes it a bit harder to reason about it that if it had true and false as valid states.

I haven't dug into the code, but I think that could be made with this change.

-const mapToStreamLiveUrlState = (value: any) => (typeof value === 'boolean' ? value : undefined);	
+const mapToStreamLiveUrlState = (value: any) => (typeof value === 'boolean' ? value : false);

Maybe you tried that already and it didn't work correctly because sometimes it wasn't being called in the right order during initialisation and the test was still flaky, but I think it might be worth a try. Otherwise I can go ahead and approve the PR

[weltenwort]

I would agree that we should prefer true/false as the two states in the URL. I wonder why the value passed to mapToStreamLiveUrlState seems to not be a boolean in the first place 🤔 maybe the cleaner fix would be to ensure that it is by making sure the source of that value is false by default and that false always gets passed down.

[afgomez]

I would agree that we should prefer true/false as the two states in the URL. I wonder why the value passed to mapToStreamLiveUrlState seems to not be a boolean in the first place

I think that happens on page load, when the URL has no values.

[Zacqary]

Just pushed another approach, I think this should actually fix it for real.

[afgomez]

👍 Perfect!

[Zacqary]

@elasticmachine merge upstream

[Zacqary]

@elasticmachine merge upstream

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: c2b597d

History

• 💚 Build #24084 succeeded 2f06bd5
• 💔 Build #23841 failed f80615e
• 💔 Build #23820 failed 19c51b0
• 💔 Build #23601 failed b4d8112
• 💚 Build #23420 succeeded 9abff9a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream