Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Root node selection #59513

Closed
ogupte opened this issue Mar 6, 2020 · 0 comments · Fixed by #59514
Closed

[APM] Root node selection #59513

ogupte opened this issue Mar 6, 2020 · 0 comments · Fixed by #59514
Assignees
@ogupte
Labels
apm:service-maps Service Map feature in APM bug Fixes for quality problems that affect the customer experience v7.7.0

Comments

@ogupte
Copy link
Contributor

ogupte commented Mar 6, 2020 •
edited
Loading

In the current layout, root nodes are selected if they are either: a rum agent node or an unconnected node. This is incorrect since it should select all nodes which have no incoming edges (which includes unconnected nodes) Cytoscape has a selector to obtain nodes with no incoming edges nodes.roots(), however when used, there are some nodes that appear to have incoming edges in the result set of root nodes.

Screen Shot 2020-03-03 at 11.41.49 AM.png

This is due to logic we added to de-duplicate symmetric edges and style one of them with bidirectional arrow indicators. Since this logic effectively removes an incoming edge, cytoscape identies it as a root node while it's styled as bidirectional. One solution is to hide one of the symmetric edges rather than omit it from the resulting graph, allowing cytoscape to effectively identify it as a non-root node.
@ogupte ogupte added [zube]: In Progress bug Fixes for quality problems that affect the customer experience apm:service-maps Service Map feature in APM release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 6, 2020
@ogupte ogupte self-assigned this Mar 6, 2020
ogupte added a commit to ogupte/kibana that referenced this issue Mar 6, 2020
@ogupte
Fixes elastic#59513 by hiding one of the symmetric edges rather than …
0f8a69d 
…omiting it

in cytoscape graph. Also selects root nodes with no incoming edges
rather than just unconnected nodes.
@ogupte ogupte mentioned this issue Mar 6, 2020
Merged
@ogupte ogupte removed the release_note:skip Skip the PR/issue when compiling release notes label Mar 6, 2020
ogupte added a commit that referenced this issue Mar 10, 2020
@ogupte @elasticmachine
Fixes #59513 by hiding one of the symmetric edges rather than omiting…
35bcb36 
… it (#59514)

in cytoscape graph. Also selects root nodes with no incoming edges
rather than just unconnected nodes.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@ogupte ogupte mentioned this issue Mar 10, 2020
Merged
ogupte added a commit to ogupte/kibana that referenced this issue Mar 10, 2020
@ogupte @elasticmachine
Fixes elastic#59513 by hiding one of the symmetric edges rather than …
61afabf 
…omiting it (elastic#59514)

in cytoscape graph. Also selects root nodes with no incoming edges
rather than just unconnected nodes.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this issue Mar 10, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
0363764 
* master: (22 commits)
  Generate docs from data plugin (elastic#56955)
  Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514)
  Harden creation of child processes (elastic#55697)
  [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475)
  [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553)
  chore: 🤖 hide Drilldowns in master (elastic#59698)
  [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175)
  Use HTTP request schemas to create types, use those types in the client (elastic#59340)
  [Maps] Support categorical styling for numbers and dates (elastic#57908)
  [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665)
  Fix slm_ui setting by changing camel case back to snake case. (elastic#59663)
  removes beta tag (elastic#59618)
  [DOCS] Removed spatial references (elastic#59595)
  fix outdated docs (elastic#58729)
  [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639)
  [ML] Refactoring anomaly detector job types (elastic#59556)
  [Upgrade Assistant] Better handling of closed indices (elastic#58890)
  additional visualizations plugin cleanup before moving to NP (elastic#59318)
  In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285)
  [Visualize] Remove global state in visualize (elastic#58352)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this issue Mar 10, 2020
@gmmorris
Merge branch 'alerting/fix-flaky-instance-test' of github.com:gmmorri…
ea98883 
…s/kibana into alerting/fix-flaky-instance-test

* 'alerting/fix-flaky-instance-test' of github.com:gmmorris/kibana: (176 commits)
  Generate docs from data plugin (elastic#56955)
  Fixes elastic#59513 by hiding one of the symmetric edges rather than omiting it (elastic#59514)
  Harden creation of child processes (elastic#55697)
  [Alerting] replace watcher http APIs used by index threshold Alerting (elastic#59475)
  [Maps][docs] add more details to Quantitative data driven styling docs (elastic#59553)
  chore: 🤖 hide Drilldowns in master (elastic#59698)
  [Discover] Migrate AppState/GlobalState to new app state helpers (elastic#57175)
  Use HTTP request schemas to create types, use those types in the client (elastic#59340)
  [Maps] Support categorical styling for numbers and dates (elastic#57908)
  [ML] Functional API tests - bucket span estimation with custom search.max_buckets (elastic#59665)
  Fix slm_ui setting by changing camel case back to snake case. (elastic#59663)
  removes beta tag (elastic#59618)
  [DOCS] Removed spatial references (elastic#59595)
  fix outdated docs (elastic#58729)
  [ML] Fixes bucket span estimators loading of max_buckets setting (elastic#59639)
  [ML] Refactoring anomaly detector job types (elastic#59556)
  [Upgrade Assistant] Better handling of closed indices (elastic#58890)
  additional visualizations plugin cleanup before moving to NP (elastic#59318)
  In scripted fields, unable to switch the `Type` - getting a console error which says - Class constructor DecoratedFieldFormat cannot be invoked without 'new' (elastic#59285)
  [Visualize] Remove global state in visualize (elastic#58352)
  ...
ogupte added a commit that referenced this issue Mar 10, 2020
@ogupte @elasticmachine
Fixes #59513 by hiding one of the symmetric edges rather than omiting…
b89727e 
… it (#59514) (#59722)

in cytoscape graph. Also selects root nodes with no incoming edges
rather than just unconnected nodes.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jkelastic pushed a commit to jkelastic/kibana that referenced this issue Mar 12, 2020
@ogupte @elasticmachine @jkelastic
Fixes elastic#59513 by hiding one of the symmetric edges rather than …
e45a652 
…omiting it (elastic#59514)

in cytoscape graph. Also selects root nodes with no incoming edges
rather than just unconnected nodes.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogupte ogupte

Labels
apm:service-maps Service Map feature in APM bug Fixes for quality problems that affect the customer experience v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Service map layout root nodes fix ogupte/kibana
2 participants
@sorenlouv @ogupte