Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data.search.aggs] Support diversified sampler in AggConfigs #67388

Closed
10 tasks
Tracked by #60126
lukeelmers opened this issue May 26, 2020 · 1 comment · Fixed by #120135
Closed
10 tasks
Tracked by #60126

[data.search.aggs] Support diversified sampler in AggConfigs #67388

lukeelmers opened this issue May 26, 2020 · 1 comment · Fixed by #120135
Labels
enhancement New value added to drive a business result Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort

Comments

@lukeelmers
Copy link
Member

Part of #60126
Related to #25983 - might be worth tackling both at once

This issue tracks support for diversified sampler aggregations in AggConfigs. Adding this agg type will unblock apps like Visualize and Lens from supporting these aggs in the future.

  • add new agg type
    • create the agg type
    • export an interface for the agg type's params
    • update AggParamsMapping in types.ts
    • register agg type via agg_types.ts
    • unit tests
  • add agg type expression function
    • write the expression function
    • register expression function via agg_types.ts
    • unit tests
@lukeelmers lukeelmers added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) enhancement New value added to drive a business result Team:AppArch labels May 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@rayafratkina rayafratkina mentioned this issue May 26, 2020
Closed
7 tasks
@lukeelmers lukeelmers mentioned this issue May 26, 2020
Closed
82 tasks
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Nov 22, 2021
@Dosant Dosant mentioned this issue Dec 6, 2021
Merged
@Dosant Dosant mentioned this issue Dec 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Sampler & Diversified Sampler aggs to AggConfigs Dosant/kibana
2 participants
@lukeelmers @elasticmachine