-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sampler & Diversified Sampler aggs to AggConfigs #120135
Conversation
@elasticmachine merge upstream |
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
Still shows up in the table vis:
Side note - the recently added |
@flash1293, will do 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
…nto d/2021-11-30-sampler-agg
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VisEditors stuff LGTM, thanks!
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
close #25983
close #67388
This pr adds sampler and diversified sampler aggs to AggConfigs and Expressions
As these are filtering bucket aggregations it is implemented similar to filter aggregation
This is only an app-services change so downstream team still need to utilize this API in their apps.