Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sampler & Diversified Sampler aggs to AggConfigs #120135

Merged
merged 12 commits into from
Dec 8, 2021

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Dec 1, 2021

Summary

close #25983
close #67388

This pr adds sampler and diversified sampler aggs to AggConfigs and Expressions

As these are filtering bucket aggregations it is implemented similar to filter aggregation

This is only an app-services change so downstream team still need to utilize this API in their apps.

@Dosant
Copy link
Contributor Author

Dosant commented Dec 6, 2021

@elasticmachine merge upstream

@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:AppServicesSv v8.1.0 Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) labels Dec 6, 2021
@Dosant Dosant changed the title add sampler agg Add Sampler & Diversified Sampler aggs to AggConfigs Dec 6, 2021
@Dosant Dosant marked this pull request as ready for review December 6, 2021 10:15
@Dosant Dosant requested review from a team as code owners December 6, 2021 10:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@Dosant Dosant requested a review from ppisljar December 6, 2021 10:15
@flash1293
Copy link
Contributor

Still shows up in the table vis:

Side note - the recently added multi_terms should be excluded from this list as well, could you add it along with sampler and diversified sampler?

@Dosant
Copy link
Contributor Author

Dosant commented Dec 6, 2021

Side note - the recently added multi_terms should be excluded from this list as well, could you add it along with sampler and diversified sampler?

@flash1293, will do 👍
This is how I was looking for places where to exclude them. I've searched for multi_terms and that's explain how I missed these :)

Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

@flash1293
Copy link
Contributor

@elasticmachine merge upstream

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VisEditors stuff LGTM, thanks!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 505 509 +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2896 2904 +8

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 438.7KB 442.9KB +4.2KB
visTypeHeatmap 10.1KB 10.2KB +102.0B
visTypeMetric 8.7KB 8.7KB +34.0B
visTypePie 13.9KB 14.0KB +68.0B
visTypeTable 14.9KB 15.0KB +98.0B
visTypeVislib 18.6KB 18.6KB +68.0B
visTypeXy 40.5KB 40.9KB +408.0B
total +5.0KB
Unknown metric groups

API count

id before after diff
data 3304 3318 +14

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 2e57f00 into elastic:main Dec 8, 2021
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Dec 8, 2021
TinLe pushed a commit to TinLe/kibana that referenced this pull request Dec 22, 2021
gbamparop pushed a commit to gbamparop/kibana that referenced this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) release_note:skip Skip the PR/issue when compiling release notes v8.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data.search.aggs] Support diversified sampler in AggConfigs Sampler Aggregation
6 participants