-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APM UI fixes for TypeScript 3.9 #67804
Comments
Pinging @elastic/apm-ui (Team:apm) |
Made some fixes and set to blocked. See my comments on #67666. |
smith
added a commit
to mshustov/kibana
that referenced
this issue
Jun 4, 2020
* Remove paramaterization from `removeEmpty in agent config SettingsPage component (it's only used there and doesn't need to be parameterized.) * Add option chain for case in registerTransactionDurationAlertType * Cast `overallValue` in transform_metrics_chart * Use more specific type for custom link filters * Add more option chaining for local UI filters buckets response * Remove unused parameters from routes * Fix getProjection type parameter * Use destructuring in serviceNodesLocalFiltersRoute to hide `never` error * Revert `UnionToIntersection` change in `AggregationResponseMap` Fixes elastic#67804.
mshustov
added a commit
to mshustov/kibana
that referenced
this issue
Jun 11, 2020
* add babel support for export type * bump ts version to 3.9.3 * rebuild kbn-pm * bump typescript-eslint * fix error in security plugin UI * check export as works * fix app migration type * use correct test subj attribute * fix errors from the old PR * embeddable is already passed in props * explicitly define type of fetch * add some types for viz * fix fetch type p.2 * add null to allow spreading without type errors due to override * add type guard to fix type error * cast to any, since cannot assign unknown * add timestamp to known types * fix type error in fetch * fix type error. id is always defined in attibutes * declare a type * move ts-ignore to the lines with errors * declare tuple type explicitly * mute type error. cannot assign unknown * fix errors. id is always defined * fix error type * fix override errors. id is always defined * fix error. extends any doesn't work anymore * fix type error. type is always defined * env doesn't always contain values * fix type error * cast to string * add: logs is already declared in getNodeLogsUrl * state is already passed in props * fix some errors in timelion * number of fragments is always defined * 'absolute' is not just string, but value * TEMP: option is always defined * always true if cast to promise manually * both props are always defined * explicitly define returned SO type * workaround type * bump tslib to be compatible with ts v3.9 * test private property * rebuild kbn-pm * Fix ts errors for beats management * Fix type inference broken by the TS 3.9 upgrade * Fix ingest manager saved object attributes typings * Fix TS errors in cross_cluster_replication and index_management. * Fix TS error in Watcher. * roll back colorRange wrong type * fix security plugin types * TypeScript 3.9 fixes for APM * Fix ColorRange types. * fix actions & alerts errors. ByGidi * fix lists error * More APM fixes * Remove paramaterization from `removeEmpty in agent config SettingsPage component (it's only used there and doesn't need to be parameterized.) * Add option chain for case in registerTransactionDurationAlertType * Cast `overallValue` in transform_metrics_chart * Use more specific type for custom link filters * Add more option chaining for local UI filters buckets response * Remove unused parameters from routes * Fix getProjection type parameter * Use destructuring in serviceNodesLocalFiltersRoute to hide `never` error * Revert `UnionToIntersection` change in `AggregationResponseMap` Fixes elastic#67804. * fix platform type error * Fix visualizations types. * Fix data plugin types. * bump TS version to 3.9.5 * Fix telemetry TS errors * Fix dashboard code * Adding Canvas Fixes for TS 3.9 * Fix case and security_solution types * roll back to the old export syntax. new one might cause problems in api-extractor * update docs * Fix timelion code * Fix meta * Fix types * fix type errors om ingest_manager * bump babel deps * enable private props & methods syntax * update kbn-pm dist * whitelist 0BSD license * use @babel/plugin-proposal-private-methods in default set as well * disable new babel plugins * Revert "disable new babel plugins" This reverts commit 04d9594. * cleanup security_solution types * Fixes type error for newer TypeScript * update docs Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> Co-authored-by: Felix Stürmer <stuermer@weltenwort.de> Co-authored-by: CJ Cenizal <cj@cenizal.com> Co-authored-by: Larry Gregory <larry.gregory@elastic.co> Co-authored-by: Nathan L Smith <smith@nlsmith.com> Co-authored-by: Walter Rafelsberger <walter@elastic.co> Co-authored-by: Luke Elmers <luke.elmers@elastic.co> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> Co-authored-by: Tim Roes <tim.roes@elastic.co> Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> Co-authored-by: FrankHassanabad <frank.hassanabad@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mshustov
added a commit
that referenced
this issue
Jun 11, 2020
* add babel support for export type * bump ts version to 3.9.3 * rebuild kbn-pm * bump typescript-eslint * fix error in security plugin UI * check export as works * fix app migration type * use correct test subj attribute * fix errors from the old PR * embeddable is already passed in props * explicitly define type of fetch * add some types for viz * fix fetch type p.2 * add null to allow spreading without type errors due to override * add type guard to fix type error * cast to any, since cannot assign unknown * add timestamp to known types * fix type error in fetch * fix type error. id is always defined in attibutes * declare a type * move ts-ignore to the lines with errors * declare tuple type explicitly * mute type error. cannot assign unknown * fix errors. id is always defined * fix error type * fix override errors. id is always defined * fix error. extends any doesn't work anymore * fix type error. type is always defined * env doesn't always contain values * fix type error * cast to string * add: logs is already declared in getNodeLogsUrl * state is already passed in props * fix some errors in timelion * number of fragments is always defined * 'absolute' is not just string, but value * TEMP: option is always defined * always true if cast to promise manually * both props are always defined * explicitly define returned SO type * workaround type * bump tslib to be compatible with ts v3.9 * test private property * rebuild kbn-pm * Fix ts errors for beats management * Fix type inference broken by the TS 3.9 upgrade * Fix ingest manager saved object attributes typings * Fix TS errors in cross_cluster_replication and index_management. * Fix TS error in Watcher. * roll back colorRange wrong type * fix security plugin types * TypeScript 3.9 fixes for APM * Fix ColorRange types. * fix actions & alerts errors. ByGidi * fix lists error * More APM fixes * Remove paramaterization from `removeEmpty in agent config SettingsPage component (it's only used there and doesn't need to be parameterized.) * Add option chain for case in registerTransactionDurationAlertType * Cast `overallValue` in transform_metrics_chart * Use more specific type for custom link filters * Add more option chaining for local UI filters buckets response * Remove unused parameters from routes * Fix getProjection type parameter * Use destructuring in serviceNodesLocalFiltersRoute to hide `never` error * Revert `UnionToIntersection` change in `AggregationResponseMap` Fixes #67804. * fix platform type error * Fix visualizations types. * Fix data plugin types. * bump TS version to 3.9.5 * Fix telemetry TS errors * Fix dashboard code * Adding Canvas Fixes for TS 3.9 * Fix case and security_solution types * roll back to the old export syntax. new one might cause problems in api-extractor * update docs * Fix timelion code * Fix meta * Fix types * fix type errors om ingest_manager * bump babel deps * enable private props & methods syntax * update kbn-pm dist * whitelist 0BSD license * use @babel/plugin-proposal-private-methods in default set as well * disable new babel plugins * Revert "disable new babel plugins" This reverts commit 04d9594. * cleanup security_solution types * Fixes type error for newer TypeScript * update docs Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> Co-authored-by: Felix Stürmer <stuermer@weltenwort.de> Co-authored-by: CJ Cenizal <cj@cenizal.com> Co-authored-by: Larry Gregory <larry.gregory@elastic.co> Co-authored-by: Nathan L Smith <smith@nlsmith.com> Co-authored-by: Walter Rafelsberger <walter@elastic.co> Co-authored-by: Luke Elmers <luke.elmers@elastic.co> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> Co-authored-by: Tim Roes <tim.roes@elastic.co> Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> Co-authored-by: FrankHassanabad <frank.hassanabad@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co> Co-authored-by: Felix Stürmer <stuermer@weltenwort.de> Co-authored-by: CJ Cenizal <cj@cenizal.com> Co-authored-by: Larry Gregory <larry.gregory@elastic.co> Co-authored-by: Nathan L Smith <smith@nlsmith.com> Co-authored-by: Walter Rafelsberger <walter@elastic.co> Co-authored-by: Luke Elmers <luke.elmers@elastic.co> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co> Co-authored-by: Tim Roes <tim.roes@elastic.co> Co-authored-by: Clint Andrew Hall <clint.hall@elastic.co> Co-authored-by: Patryk Kopycinski <contact@patrykkopycinski.com> Co-authored-by: FrankHassanabad <frank.hassanabad@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#67666 bumps us to TS 3.9, but there are outstanding issues for APM at these locations:
Changes can be made on #67666.
The text was updated successfully, but these errors were encountered: