Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build after pleaserun updates #7265

Closed
PavelVanecek opened this issue May 23, 2016 · 2 comments
Closed

Cannot build after pleaserun updates #7265

PavelVanecek opened this issue May 23, 2016 · 2 comments

Comments

@PavelVanecek
Copy link
Contributor

PavelVanecek commented May 23, 2016

Sometimes between Apr 30 and May 20 our builds stopped working. I am running the 4.4 branch only.
I've been following the guide and came up with this Dockerfile (which used to work for several months just fine):

FROM node:4.3 # comes from debian:jessie
RUN apt-get update && apt-get install -y zip ruby ruby-dev rubygems
RUN gem install pleaserun fpm
WORKDIR /kibana
COPY . .
RUN npm install
CMD ["npm", "run", "build:ospackages", "--", "--deb"]

I am suspicious that it has something to do with new versions of pleaserun.
These are errors I am seeing with pleaserun versions:

  1. pleaserun:0.0.24
Running "_build:osPackages" task
# ...
{:timestamp=>"2016-05-23T10:51:05.582995+0000", :message=>"Invalid package configuration: Cannot package the path '/kibana/build/services/systemd/lib', does it exist?", :level=>:error}
Warning: Command failed: fpm --force --package /kibana/target -s dir --name kibana --description Explore and visualize your Elasticsearch data. --version 4.4.3-snapshot --url https://www.elastic.co --vendor Elasticsearch, Inc. --maintainer Kibana Team <info@elastic.co> --license Apache 2.0 --after-install /kibana/build/userScripts/installer.sh --after-remove /kibana/build/userScripts/remover.sh --config-files /opt/kibana/config/kibana.yml -t deb --deb-priority optional -a x86_64 /kibana/build/kibana-4.4.3-snapshot-linux-x64/=/opt/kibana /kibana/build/services/sysv/etc/=/etc/ /kibana/build/services/systemd/lib/=/lib/� Use --force to continue.

When I browse the project, indeed the folder build/services/systemd/lib does not exist.

  1. pleaserun:0.0.23 - 22
Running "_build:pleaseRun" task
# ...
/var/lib/gems/2.1.0/gems/pleaserun-0.0.22/lib/pleaserun/cli.rb:116:in `block in execute': undefined method `unit_path' for #<PleaseRun::CLI:0x00000000ef2130> (NoMethodError)
from /var/lib/gems/2.1.0/gems/pleaserun-0.0.23/lib/pleaserun/cli.rb:113:in `each'
    from /var/lib/gems/2.1.0/gems/pleaserun-0.0.23/lib/pleaserun/cli.rb:113:in `execute'
    from /var/lib/gems/2.1.0/gems/clamp-1.0.0/lib/clamp/command.rb:68:in `run'
    from /var/lib/gems/2.1.0/gems/clamp-1.0.0/lib/clamp/command.rb:133:in `run'
    from /var/lib/gems/2.1.0/gems/pleaserun-0.0.23/bin/pleaserun:6:in `<top (required)>'
    from /usr/local/bin/pleaserun:23:in `load'
    from /usr/local/bin/pleaserun:23:in `<main>'
Warning: Command failed: pleaserun --install --no-install-actions --install-prefix /kibana/build/services/systemd --overwrite --user kibana --sysv-log-path /var/log/kibana/ -p systemd -v default /opt/kibana/bin/kibana� Use --force to continue.�

My workaround is to rollback to pleaserun:0.0.21 and the build works:

RUN gem install pleaserun:0.0.21
# all OK now

I am not sure if this is pleaserun issue or kibana build configuration issue.

These changes seem related: #5322, #5307

Can you reproduce? What is the best way to fix it?

Some more details, I guess it might help debugging:

Correct build (with pleaserun 21) says:

Writing file {:destination=>"/kibana/build/services/systemd/lib/systemd/system/kibana.service"}

On the other hand, build with pleaserun 24 says:

Writing file {:destination=>"/kibana/build/services/systemd/etc/systemd/system/kibana.service"}

Pleaserun changelog (version 22) says:

systemd platform now defaults to targeting /etc/systemd/system for writing unit files

Commit jordansissel/pleaserun@1223773

@jbudz
Copy link
Member

jbudz commented May 23, 2016

const systemd = servicesByName.systemd.outputDir + '/lib/=/lib/';
needs to updated with the correct path, s/lib/etc

@PavelVanecek
Copy link
Contributor Author

PavelVanecek commented Jun 21, 2016

Rollback to pleaserun 21 no longer works since fpm now installs pleaserun 24 anyway: jordansissel/fpm@e2b1ca3.

I confirm that changes from #7276 fix our build too.

cee-chen added a commit that referenced this issue Nov 3, 2023
`v89.1.0`⏩`v90.0.0`

The majority of changes in this PR come from:

- **EuiContextMenu** being converted to Emotion
(elastic/eui#7312). If your usage of
`EuiContextMenu` was significantly affected, we recommend pulling down
this PR and QAing it locally.

- `defaultProps` being removed from some very widespread components,
particularly **EuiButton**, in anticipation of React's upcoming
deprecation.
(elastic/eui@b7dc9b4)
**NOTE**: This only affected Enzyme snapshots, and did not affect
production behavior.

[Commits](https://github.com/elastic/kibana/pull/170179/commits) have
been broken up by component changes as well as types of changes.

---

## [`90.0.0`](https://github.com/elastic/eui/tree/v90.0.0)

- Updated the `eventColor` prop on `EuiCommentEvent` to apply the color
to the entire comment header.
([#7288](elastic/eui#7288))
- Updated `EuiBasicTable` and `EuiInMemoryTable` to support a new
controlled selection API: `selection.selected`
([#7321](elastic/eui#7321))

**Bug fixes**

- Fixed controlled `EuiFieldNumbers` not correctly updating native
validity state ([#7291](elastic/eui#7291))
- Fixed `EuiListGroupItem` to pass `style` props to the wrapping `<li>`
element alongside `className` and `css`. All other props will be passed
to the underlying content.
([#7298](elastic/eui#7298))
- Fixed `EuiListGroupItem`'s non-transitioned transform on hover/focus
([#7298](elastic/eui#7298))
- Fixed `EuiDataGrid`s with `gridStyle.stripes` sometimes showing buggy
row striping after being sorted
([#7301](elastic/eui#7301))
- Fixed `EuiDataGrid`'s `gridStyle.rowClasses` API to not conflict with
`gridStyle.stripes` if dynamically updated
([#7301](elastic/eui#7301))
- Fixed `EuiDataGrid`'s `gridStyle.rowClasses` API to support multiple
space-separated classes
([#7301](elastic/eui#7301))
- Fixed `EuiInputPopover` not calling `onPanelResize` callback prop
([#7305](elastic/eui#7305))
- Fixed `EuiDualRange` incorrectly positioning highlights when rendered
with `showInput="inputWithPopover"`
([#7305](elastic/eui#7305))
- Fixed `EuiTabs` incorrectly wrapping text when it should instead
either scroll or truncate
([#7309](elastic/eui#7309))
- `EuiContextMenu` now renders text colors correctly when used within an
`EuiBottomBar` ([#7312](elastic/eui#7312))
- Fixed the width of `EuiSuperDatePicker`'s Absolute date picker
([#7313](elastic/eui#7313))
- Fixed `EuiDataGrid` cells visually cutting off overflowing content a
little too quickly ([#7320](elastic/eui#7320))

**Deprecations**

- Deprecated `EuiBasicTable` and `EuiInMemoryTable`'s ref `setSelection`
API. Use the new `selection.selected` API instead.
([#7321](elastic/eui#7321))

**Breaking changes**

- Removed `EuiPageTemplate_Deprecated`, `EuiPageSideBar_Deprecated`, and
`EuiPageContent*_Deprecated`
([#7265](elastic/eui#7265))
- Removed the `ghost` color option from `EuiButton`, `EuiButtonEmpty`,
and `EuiButtonIcon`. Use an `<EuiThemeProvider colorMode="dark">`
wrapper and `color="text"` instead.
([#7296](elastic/eui#7296))

**Dependency updates**

- Updated `refractor` to v3.6.0
([#7127](elastic/eui#7127))
- Updated `rehype-raw` to v5.1.0
([#7127](elastic/eui#7127))
- Updated `vfile` to v4.2.1
([#7127](elastic/eui#7127))

**Accessibility**

- `EuiContextMenu` now correctly respects reduced motion preferences
([#7312](elastic/eui#7312))
- `EuiAccordion`s no longer attempt to focus child content when the
accordion is externally opened via `forceState`, but will continue to
focus expanded content when users click the toggle button.
([#7314](elastic/eui#7314))

**CSS-in-JS conversions**

- Converted `EuiContextMenu`, `EuiContextMenuPanel`, and
`EuiContextMenuItem` to Emotion; Removed `$euiContextMenuWidth`
([#7312](elastic/eui#7312))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants