Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [XY] [Lens] Adds opacity slider (#100453) #100568

Merged
merged 1 commit into from
May 25, 2021
Merged

[7.x] [XY] [Lens] Adds opacity slider (#100453) #100568

merged 1 commit into from
May 25, 2021

Conversation

stratoula
Copy link
Contributor

Backports the following commits to 7.x:

@stratoula @kibanamachine
[XY] [Lens] Adds opacity slider (elastic#100453)
54a6074 
* [XY] Add opacity slider and dots size slider

* [Lens] Adds fill opacity slider

* Make the new sliders to appear fullwidth

* Change property name and fix unit tests

* Add a comment

* useDebouncedValue hook

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@stratoula stratoula enabled auto-merge (squash) May 25, 2021 16:04
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 558 559 +1
visTypeXy 99 100 +1
total +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 154 155 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.1MB 1.1MB +1.8KB
visTypeXy 111.6KB 113.7KB +2.1KB
total +3.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeXy 62.7KB 63.3KB +567.0B
Unknown metric groups

API count

id before after diff
lens 165 166 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit 274ca39 into elastic:7.x May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stratoula @kibanamachine