-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest pipelines] add extract_device_type to user agent processor #100986
[Ingest pipelines] add extract_device_type to user agent processor #100986
Conversation
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
@elasticmachine merge upstream |
merge conflict between base and head |
...ents/pipeline_editor/components/processor_form/processors/common_fields/properties_field.tsx
Show resolved
Hide resolved
...c/application/components/pipeline_editor/components/processor_form/processors/user_agent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @sabarasaba! Tested locally and works great. I left a couple minor comments/questions in the code.
Also, were you able to follow up with the ES team regarding #97466 (comment)? Just want to make sure this can be safely backported. Thanks!
...ents/pipeline_editor/components/processor_form/processors/common_fields/properties_field.tsx
Show resolved
Hide resolved
...c/application/components/pipeline_editor/components/processor_form/processors/user_agent.tsx
Outdated
Show resolved
Hide resolved
...c/application/components/pipeline_editor/components/processor_form/processors/user_agent.tsx
Outdated
Show resolved
Hide resolved
...c/application/components/pipeline_editor/components/processor_form/processors/user_agent.tsx
Outdated
Show resolved
Hide resolved
...c/application/components/pipeline_editor/components/processor_form/processors/user_agent.tsx
Outdated
Show resolved
Hide resolved
@alisonelizabeth They forgot to backport the docs for 7.13, but they say they will do it soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @sabarasaba. I'm going to go ahead and approve to unblock you. Happy to see the EUI changes will be merged soon and we won't need the hack!
@elasticmachine merge upstream |
merge conflict between base and head |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
…lastic#100986) * testing layouts * fix copy for beta badge * replace hardcoded text with i18n strings * avoid updating types and just replace label * Small cr changes * get rid of style prop and just use a smaller badge
Fixes: #97466
Release Note
Add support to the new
extract_device_type
option that was added to the user agent processor.