Change file data visualizer links to point to new location in home application #101393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Feature:Data Views
25 tasks
mattkime
approved these changes
Jun 7, 2021
|
@elasticmachine merge upstream |
nreese
added
the
auto-backport
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
|
7.x backport blocked until #101665 merges |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 9, 2021
* master: clarify which parts of TM are experimental (elastic#101757) Add sh scripts with _bulk_action route usage examples (elastic#101736) [Uptime] Only register route in side nav if uptime show capability is true (elastic#101709) Use KIBANA_DOCS in doc link service (elastic#101667) [Alerting][Event log] Persisting duration information for active alerts in event log (elastic#101387) Address design issues in Discover/Graph (elastic#101584) Optimize performance for document table (elastic#101715) Change file data visualizer links to point to new location in home application (elastic#101393) [Fleet] Tighten policy permissions, take II (elastic#97366) [ML] Add debounce to the severity control update (elastic#101581) [Fleet] Fix routing issues with `getPath` and `history.push` (elastic#101658) [APM] Add link-to/transaction route (elastic#101731) [Index Patterns] Runtime fields CRUD REST API (elastic#101164) [ILM] Refactor types and fix missing aria labels (elastic#101518) [Lens] New summary row feature for datatable (elastic#101075) Blocks save event filter with a white space name (elastic#101599) Improve security server types (elastic#101661) [APM] Replace side nav with tabs on Settings page (elastic#101460) [APM] Only register items in side nav if user has permissions to see app (elastic#101707) [Security solution][Endpoint] Add back button when to the event filters list (elastic#101280)
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jun 9, 2021
…plication (elastic#101393) * Link to home file data visualizer * remove unused import * i18n cleanup * remove unused import from EmptyState * use const * remove ml functional test cases checking for ml_file_data_visualizer * more clean-up of ml_file_data_visualizer * jest snapshot and nav to home page in no_ml_access tests * revert change to functional test dual_privileges_all at everything_space * revert another change to security_and_spaces/tests/catalogue.ts * revert changes to x-pack/test/ui_capabilities/security_only/tests/catalogue.ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx
|
7.x #101844 |
nreese
added a commit
that referenced
this pull request
Jun 9, 2021
…plication (#101393) (#101844) * Link to home file data visualizer * remove unused import * i18n cleanup * remove unused import from EmptyState * use const * remove ml functional test cases checking for ml_file_data_visualizer * more clean-up of ml_file_data_visualizer * jest snapshot and nav to home page in no_ml_access tests * revert change to functional test dual_privileges_all at everything_space * revert another change to security_and_spaces/tests/catalogue.ts * revert changes to x-pack/test/ui_capabilities/security_only/tests/catalogue.ts Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # src/plugins/index_pattern_management/public/components/index_pattern_table/index_pattern_table.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File data visualizer has been moved into its own plugin and is no longer a part of ml. #100863 added file data visualizer to home "Add data" page.
This PR cleans up some links to file data visualizer, changing the links from pointing to ml to instead, point to file data visualizer's new location in the home page.
"Upload a file" card now points to home "Add data" file data visualizer tab.
"Upload a file" card in index pattern management now points to home "Add data" file data visualizer tab.
This PR also removes the environment service from index_pattern_management plugin. This service was only used to register whether ml plugin is available and the license is basic. Now that Kibana is always shipped with the default distribution, I felt all of this complexity is no longer needed.