Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ts] migrate x-pack/test to composite ts project #101441

Merged
merged 6 commits into from
Jun 8, 2021

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jun 4, 2021

Compliment to #99148

Migrates the x-pack/test directory to a composite TS project which can be ref'd from other composite projects. This gets us closer to having all projects in the repo be composite and required far fewer changes than the OSS tests because many of the services/pageObjects in the x-pack/test project already return POJOs from their providers rather than returning instances of class expressions, though a few of those were in use and were extracted to sub-classes of FtrService. POJOs were left in place to reduce the amount of changes necessary to be reviewed.

@spalger spalger changed the title [ts] migrate xpack/test to ts ref'd project [ts] migrate x-pack/test to composite ts project Jun 4, 2021
@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team Team:QA Team label for QA Team v7.14.0 v8.0.0 labels Jun 7, 2021
@spalger spalger marked this pull request as ready for review June 7, 2021 18:39
@spalger spalger requested review from a team as code owners June 7, 2021 18:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces/security changes LGTM!

@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 7, 2021
@spalger spalger enabled auto-merge (squash) June 7, 2021 19:40
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML test changes LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit bdafd27 into elastic:master Jun 8, 2021
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 101441

spalger pushed a commit to spalger/kibana that referenced this pull request Jun 8, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/page_objects/gis_page.ts
#	x-pack/test/functional/page_objects/index.ts
#	x-pack/test/functional/page_objects/reporting_page.ts
spalger pushed a commit that referenced this pull request Jun 8, 2021
Co-authored-by: spalger <spalger@users.noreply.github.com>
# Conflicts:
#	x-pack/test/functional/page_objects/gis_page.ts
#	x-pack/test/functional/page_objects/index.ts
#	x-pack/test/functional/page_objects/reporting_page.ts
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 9, 2021
* master: (54 commits)
  Implement "select all" rules feature (elastic#100554)
  [ML] Remove script fields from the Anomaly detection alerting rule executor  (elastic#101607)
  [Security solutions][Endpoint] Update event filtering texts (elastic#101563)
  [Enterprise Search] Mocks/tests tech debt - avoid hungry mocking (elastic#101107)
  [FTR] Updates esArchive paths
  [FTR] Updates esArchive paths
  [Security Solution][Detection Engine] Adds runtime field tests (elastic#101664)
  Added APM PHP agent to the list of agent names (elastic#101062)
  [CI] Restore old version_info behavior when .git directory is present (elastic#101642)
  [Fleet] Add fleet server telemetry (elastic#101400)
  [APM] Syncs agent config settings to APM Fleet policies (elastic#100744)
  [esArchiver] drop support for --dir, use repo-relative paths instead (elastic#101345)
  Revert "[xpack/test] restore incremental: false in ts project"
  [Security Solution] Remove Host Isolation feature flag (elastic#101655)
  [xpack/test] restore incremental: false in ts project
  [DOCS] Adds link to video landing page (elastic#101413)
  [ML] Move Index Data Visualizer into separate plugin (Part 1) (elastic#100922)
  Improve security plugin return types (elastic#101492)
  [ts] migrate `x-pack/test` to composite ts project (elastic#101441)
  [App Search] Updated Search UI to new URL (elastic#101320)
  ...
@spalger spalger deleted the migrate-xpack-test-project-ref branch August 2, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team Team:QA Team label for QA Team v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants