Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Improve security server types (#101661) #101767

Merged
merged 1 commit into from
Jun 9, 2021
Merged

[7.x] Improve security server types (#101661) #101767

merged 1 commit into from
Jun 9, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

@stacey-gammon @kibanamachine
Improve security server types (elastic#101661)
c34de38 
* Remove RecursiveReadonly wrapper on public API items

* Remove Pick and export some types that are part of the public API

* Udpate api docs

* Export API items that are part of the public API

* Add extra comments

* update api docs
@kibanamachine kibanamachine enabled auto-merge (squash) June 9, 2021 14:14
@kibanamachine kibanamachine mentioned this pull request Jun 9, 2021
Merged
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
security 45 49 +4

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
security 11 5 -6
Unknown metric groups

API count

id before after diff
security 95 109 +14

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @stacey-gammon

@kibanamachine kibanamachine merged commit 083be95 into elastic:7.x Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stacey-gammon stacey-gammon

Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kibanamachine @stacey-gammon