-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Migrated legacy Elasticsearch client for 8.0 #101850
[Monitoring] Migrated legacy Elasticsearch client for 8.0 #101850
Conversation
…ew-es-client-for-stack-monitoring
x-pack/plugins/monitoring/server/kibana_monitoring/collectors/get_usage_collector.ts
Outdated
Show resolved
Hide resolved
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
…ew-es-client-for-stack-monitoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a typo. Looks generally good and tests pass, so happy to approve after that.
…ew-es-client-for-stack-monitoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as far as my expertise goes here. Looks like the test failure should get addressed by #84440 so approving ahead of time.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]History
To update your PR or re-run it, just comment with: |
@simianhacker is this still planned for |
@pgayvallet yes, just merged |
Summary
This PR migrates the legacy client to the new client per #83910 closes #102143
Checklist