-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution, Lists] Replace legacy imports from 'elasticsearch' package #107226
Commits on Jul 29, 2021
-
Remove legacy imports from 'elasticsearch' package
This prefers the newer types from '@elastic/elasticsearch'. There was one instance where mock data was insufficient to satisfy the newer analogous types; in all other cases this was just a find/replace.
Configuration menu - View commit details
-
Copy full SHA for 74d09fe - Browse repository at this point
Copy the full SHA 74d09feView commit details -
Fix type errors with a null guard
We know that this mock has hits with _source values, but we cannot convey this to typescript as null assertions are disabled within this project. This seems like the next best solution, preferable to a @ts-expect-error.
Configuration menu - View commit details
-
Copy full SHA for a108af5 - Browse repository at this point
Copy the full SHA a108af5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8746a88 - Browse repository at this point
Copy the full SHA 8746a88View commit details
Commits on Aug 2, 2021
-
Replace legacy type imports in integration tests
* refactors destructuring due to _source being properly declared as conditional
Configuration menu - View commit details
-
Copy full SHA for ef54ff6 - Browse repository at this point
Copy the full SHA ef54ff6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c9bc3e - Browse repository at this point
Copy the full SHA 6c9bc3eView commit details -
Update more integration tests to account for our optional _source
Changes here fall into one of two categories: * If the test was making an assertion on a value from _source, we simply null chain and continue to assert on a possibly undefined value. * If the test logic depends on _source being present, we first assert that presence, and exit the test early if absent.
Configuration menu - View commit details
-
Copy full SHA for 93aa2db - Browse repository at this point
Copy the full SHA 93aa2dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2f31cb - Browse repository at this point
Copy the full SHA e2f31cbView commit details
Commits on Aug 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 765e6c9 - Browse repository at this point
Copy the full SHA 765e6c9View commit details
Commits on Aug 4, 2021
-
Merge branch 'master' into replace-legacy-secsol-imports
Conflicts: x-pack/plugins/security_solution/public/cases/components/case_view/index.tsx
Configuration menu - View commit details
-
Copy full SHA for 34fb078 - Browse repository at this point
Copy the full SHA 34fb078View commit details
Commits on Aug 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 63aa115 - Browse repository at this point
Copy the full SHA 63aa115View commit details