Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution, Lists] Replace legacy imports from 'elasticsearch' package #107226

Merged
merged 10 commits into from
Aug 5, 2021

Commits on Jul 29, 2021

  1. Remove legacy imports from 'elasticsearch' package

    This prefers the newer types from '@elastic/elasticsearch'.
    
    There was one instance where mock data was insufficient to satisfy the
    newer analogous types; in all other cases this was just a find/replace.
    rylnd committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    74d09fe View commit details
    Browse the repository at this point in the history
  2. Fix type errors with a null guard

    We know that this mock has hits with _source values, but we cannot
    convey this to typescript as null assertions are disabled within this
    project. This seems like the next best solution, preferable to a
    @ts-expect-error.
    rylnd committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    a108af5 View commit details
    Browse the repository at this point in the history
  3. Fix a few more type errors

    rylnd committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    8746a88 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. Replace legacy type imports in integration tests

    * refactors destructuring due to _source being properly declared as
      conditional
    rylnd committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    ef54ff6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6c9bc3e View commit details
    Browse the repository at this point in the history
  3. Update more integration tests to account for our optional _source

    Changes here fall into one of two categories:
    
    * If the test was making an assertion on a value from _source, we simply
    null chain and continue to assert on a possibly undefined value.
    
    * If the test logic depends on _source being present, we first assert that
    presence, and exit the test early if absent.
    rylnd committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    93aa2db View commit details
    Browse the repository at this point in the history
  4. Fix more type errors

    rylnd committed Aug 2, 2021
    Configuration menu
    Copy the full SHA
    e2f31cb View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2021

  1. Configuration menu
    Copy the full SHA
    765e6c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2021

  1. Merge branch 'master' into replace-legacy-secsol-imports

     Conflicts:
    	x-pack/plugins/security_solution/public/cases/components/case_view/index.tsx
    rylnd committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    34fb078 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2021

  1. Configuration menu
    Copy the full SHA
    63aa115 View commit details
    Browse the repository at this point in the history