Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data.search] Remove deprecated courier:batchSearches advanced setting #109350

Merged
merged 27 commits into from
Aug 23, 2021

Conversation

lukasolson
Copy link
Member

Summary

Resolves #55140.

Removes the courier:batchSearches advanced setting and its usage, as it has been deprecated since 7.6 (#54539).

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

Release note

Removes the deprecated courier:batchSearches advanced setting which allowed using the Elasticsearch _searchAPI instead of _async_search.

lukasolson and others added 24 commits June 29, 2021 12:15
@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana release_note:breaking v8.0.0 Team:AppServices auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Aug 19, 2021
@lukasolson lukasolson requested a review from a team as a code owner August 19, 2021 22:05
@lukasolson lukasolson self-assigned this Aug 19, 2021
@lukasolson lukasolson requested review from a team as code owners August 19, 2021 22:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

Copy link
Contributor

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for the core changes

@Dosant
Copy link
Contributor

Dosant commented Aug 20, 2021

Do we leave it as 8.0 change or do we also back port this to 7.x?

@lukasolson lukasolson removed auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Aug 20, 2021
@lukasolson
Copy link
Member Author

Do we leave it as 8.0 change or do we also back port this to 7.x?

Thanks for catching this, I added the 7.x and auto-backport labels out of habit. I've removed them now.

@lukasolson lukasolson requested a review from Dosant August 20, 2021 23:01
@Dosant
Copy link
Contributor

Dosant commented Aug 23, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 549 547 -2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 790.1KB 788.9KB -1.2KB
Unknown metric groups

API count

id before after diff
data 3502 3498 -4

API count missing comments

id before after diff
data 2985 2981 -4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lukasolson

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and ci is happy. didn't test

@lukasolson lukasolson merged commit 0a8d42c into elastic:master Aug 23, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 25, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 109350 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 109350 or prevent reminders by adding the backport:skip label.

@lukasolson lukasolson added the backport:skip This commit does not require backporting label Aug 27, 2021
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Search Querying infrastructure in Kibana release_note:breaking review v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove courier:batchSearches setting and usage of _msearch APIs
5 participants