Change legacy audit logger deprecation warning #110527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently showing as a "Critical" issue in the upgrade assistant. However, we have decided not to remove the legacy audit logger in the 8.0 release. So I am leaving this deprecated in the docs "for an upcoming version", but removing the deprecation warning in the config, since we cannot currently mark this as a non-critical issue.
jportner
added
release_note:skip
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
jportner
added
the
auto-backport
thomheymann
reviewed
Sep 1, 2021
We went back and forth on what to do about the legacy audit logger in 8.0, but we decided to remove it after all. I am tracking all of our 8.0 upgrade work in #111160. |
jportner
deleted the
issue-82578-change-legacy-audit-logger-deprecation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit
This PR is still a WIP. Not ready for review.
Partially resolves #82578.
This is currently showing as a "Critical" issue in the upgrade assistant. However, we have decided not to remove the legacy audit logger in the 8.0 release. So I am leaving this deprecated in the docs "for an upcoming version", but removing the deprecation warning in the config, since we cannot currently mark this as a non-critical issue and the upgrade assistant assumes that users will be affected in the 8.0 release (they will not be).
Note: intentionally merging this into 7.x and backporting to 7.15 (skipping the master branch).