[Security Solution][Endpoint] Remove refresh button from policy trusted apps flyout #114974
Conversation
dasansol92
added
v8.0.0
release_note:skip
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
| loading: false, | ||
| canAccessEndpointManagement: true, | ||
| canAccessFleet: false, | ||
| isPlatinumPlus: true, |
There was a problem hiding this comment.
FYI - a mock is already loaded when you just do:
jest.mock('../../../common/components/user_privileges/use_endpoint_privileges');
see: x-pack/plugins/security_solution/public/common/components/user_privileges/__mocks__
Not related to this PR, but
@parkiino :
I'm just seeing this now and I apologize for not having reviewed your original PR on this:
This really does not feel like the right name for a privilege. The items here (and the actual implementation) should be names that imply what the user can do, not what the system is setup for. So if this one is being used to detect if a user can do artifacts by policy, then the key should be: canUserCreateArtifactsByPolicy. this will scale better if we ever implement other restrictions (ex. page level user permissions) in that we will not have to re-implement logic in places that check for this privilege value.
We should correct this before others start using it.
There was a problem hiding this comment.
Do you want me to fix this name in this pr?
There was a problem hiding this comment.
fixing it might have broader implication - I'm not sure how @parkiino is using it
There was a problem hiding this comment.
just chatted with Candace - don't worry about that key for now. we'll address it in a separate PR
There was a problem hiding this comment.
About the mock, is there a way to set the isPlatinumPlus to true/false just doing this jest.mock('../../../common/components/user_privileges/use_endpoint_privileges');?
There was a problem hiding this comment.
yeah, you should be able to:
jest.mock('../../../common/components/user_privileges/use_endpoint_privileges')
const useEndpointPrivilegesMock: jest.Mock = useEndpointPrivileges;
// now mock your responses
useEndpointPrivilegesMock.mockReturnValue({
/*...*/
isPlatinumPlus: false
});The mock defines useEndpointPrivileges() as a mocked function, so you can override it:
There was a problem hiding this comment.
ahá! got it, will do it in this pr in a bit
There was a problem hiding this comment.
@paul-tavares done in b876996
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…ed apps flyout (elastic#114974) * Hide refresh button by prop and refactor unit test * Add test cases for policies selector when enable/disable license * Remove unused code when adding mock
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…ed apps flyout (elastic#114974) * Hide refresh button by prop and refactor unit test * Add test cases for policies selector when enable/disable license * Remove unused code when adding mock
Summary
For maintainers