Remove unused title attribute from saved-object-finder. #11548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
the
Team:Platform-Design
- Add aria-hidden to global nav icon.
cjcenizal
force-pushed
the
11520/improvement/accessibility-alt-text
branch
from
c91abee
to
9650afe
Compare
cjcenizal
changed the title
|
jenkins, test this |
cjcenizal
force-pushed
the
11520/improvement/accessibility-alt-text
branch
from
732aee8
to
4bafa03
Compare
cjcenizal
force-pushed
the
11520/improvement/accessibility-alt-text
branch
from
4bafa03
to
0c1281c
Compare
This was referenced May 4, 2017
cjcenizal
force-pushed
the
11520/improvement/accessibility-alt-text
branch
from
0c1281c
to
a4cbcb0
Compare
cjcenizal
commented
May 4, 2017
| @@ -28,6 +27,10 @@ | |||
| </div> | |||
|
|
|||
| <div class="list-group-item list-group-item--noBorder" ng-switch-when="search"> | |||
| <saved-object-finder title="Choose a search" type="searches" use-local-management="true" on-choose="opts.addSearch"></saved-object-finder> | |||
| <saved-object-finder | |||
| type="searches" | |||
There was a problem hiding this comment.
Looks like the title attribute isn't used, so I removed it.
cjcenizal
commented
May 4, 2017
| <img | ||
| ng-if="icon" | ||
| class="global-nav-link__icon-image" | ||
| kbn-src="{{ '/' + icon }}" | ||
| alt="" | ||
| aria-hidden |
There was a problem hiding this comment.
This image means nothing to screen readers, so we hide it.
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
May 11, 2017
…lastic#11548) * Ensure img elements have alt text where necessary (none do). - Add aria-hidden to global nav icon. * Remove unused title attribute from SavedObjectFinder.
cjcenizal
changed the title
snide
pushed a commit
to snide/kibana
that referenced
this pull request
May 30, 2017
…lastic#11548) * Ensure img elements have alt text where necessary (none do). - Add aria-hidden to global nav icon. * Remove unused title attribute from SavedObjectFinder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #11520.