Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't prevent filterable rows from being filterable #11628

Merged
merged 5 commits into from
May 9, 2017
Merged

Don't prevent filterable rows from being filterable #11628

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2cfd7af
Don't prevent filterable rows just because they don't have a field
lukasolson May 5, 2017
3a09f3d
Merge branch 'master' into data-table-filters
lukasolson May 8, 2017
9890337
Don't allow filtering on unfilterable fields
lukasolson May 8, 2017
6642fd5
Move isFilterable to aggConfig
lukasolson May 8, 2017
eb989dc
Merge branch 'master' into data-table-filters
lukasolson May 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/ui/public/directives/rows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ module.directive('kbnRows', function ($compile, $rootScope, getAppState, Private
let $cellContent;

if (contents instanceof AggConfigResult) {
const field = contents.aggConfig.getField();
const isCellContentFilterable =
contents.type === 'bucket'
&& contents.aggConfig.getField()
&& contents.aggConfig.getField().filterable;
_.get(contents, 'aggConfig.type.createFilter')
&& (!field || field.filterable);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd consider moving this check to the AggConfig type instead. Then you could do something like if (aggConfig.isFilterable()), and we don't need to ducktype this here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukasolson lemme know if you wanna take a crack at this, if so I'll hold off on giving it another look. Otherwise I'll do another review first thing tomorrow.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bargs Just fixed this. Feel free to take a look now. Thanks!

if (isCellContentFilterable) {
$cell = createFilterableCell(contents);
Expand Down