[Fleet] Fix - Increment system package name when adding agent policy with monitoring #118403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criamico
added
v8.0.0
Team:Fleet
criamico
force-pushed
the
fix_agent_policy_unique
branch
from
5d2d836
to
6361447
Compare
|
Pinging @elastic/fleet (Team:Fleet) |
criamico
added
the
release_note:skip
joshdover
approved these changes
Nov 15, 2021
| ? systemPackagePolicyData.items | ||
| .filter((ds) => Boolean(ds.name.match(pkgPoliciesNamePattern))) | ||
| .map((ds) => parseInt(ds.name.match(pkgPoliciesNamePattern)![1], 10)) | ||
| .sort((a, b) => a - b) |
There was a problem hiding this comment.
nit: I don't think the sort implementation is necessary?
Suggested change
| .sort((a, b) => a - b) | |
| .sort() |
criamico
force-pushed
the
fix_agent_policy_unique
branch
from
6361447
to
7a80b79
Compare
criamico
force-pushed
the
fix_agent_policy_unique
branch
from
7a80b79
to
081230c
Compare
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @criamico |
|
The following labels were identified as gaps in your version labels and will be added automatically:
If any of these should not be on your pull request, please manually remove them. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 15, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 15, 2021
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Nov 17, 2021
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 19, 2021
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
…with monitoring (#118403)
roeehub
pushed a commit
to build-security/kibana
that referenced
this pull request
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118357
Summary
Adding an agent policy with "Collect system logs and metric" checkbox enabled triggers the error
There is already a package with the same nameThis bug was caused by the unique names PR: when we add a new agent policy with the system monitoring enabled we automatically install the
systempackage, but the name given to the integration was always the same (system-1). Since we are now checking that all the integration packages have a unique name, the installation fails with the above error.In this PR I'm adding a function that fetches all the
systemintegrations already installed and increment the name, like it was done in the previous PR.Steps to reproduce:
systemintegration with incremental name format (something likesystem-1,system-2...)Checklist
For maintainers