[TypeScript] Upgrade to 4.5.3 #120812
Merged
[TypeScript] Upgrade to 4.5.3 #120812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianseeders
added
Feature:CI
brianseeders
force-pushed
the
ts-4-5-2
branch
from
be1ec3c
to
565c1d6
Compare
brianseeders
requested review from
vigneshshanmugam and
a team
as code owners
ThomThomson
approved these changes
Dec 9, 2021
There was a problem hiding this comment.
Presentation team changes LGTM! Thank you for ignoring the TS errors. I have created an issue to track our TODO to update those files.
|
35% faster?! Yes, please! Running: ts-4-5-2: main: |
tylersmalley
approved these changes
Dec 9, 2021
jbudz
approved these changes
Dec 9, 2021
mshustov
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
OK for the Core changes.
Please note the current PR updates TS to v4.5 but developers can't use some new TypeScript features until other code analysis tools are updated to versions with TypeScript v4.5 support:
https://github.com/typescript-eslint/typescript-eslint/releases/tag/v5.6.0
https://github.com/babel/babel/releases/tag/v7.16.0
https://prettier.io/blog/2021/11/25/2.5.0.html
academo
approved these changes
Dec 13, 2021
peteharverson
approved these changes
Dec 13, 2021
yuliacech
approved these changes
Dec 13, 2021
janmonschke
reviewed
Dec 13, 2021
| @@ -23,7 +23,9 @@ export const AutoDownload: React.FC<AutoDownloadProps> = ({ blob, name, onDownlo | |||
|
|
|||
| useEffect(() => { | |||
| if (blob && anchorRef?.current) { | |||
| // @ts-expect-error | |||
| if (typeof window.navigator.msSaveOrOpenBlob === 'function') { | |||
There was a problem hiding this comment.
Unrelated to the PR: we should probably not ship this code anymore since it's an API that was just supported by Internet Explorer. (takes a mental note to create a follow-up PR)
brianseeders
changed the title
justinkambic
approved these changes
Dec 13, 2021
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Jan 12, 2022
3 tasks
mistic
pushed a commit
to mistic/kibana
that referenced
this pull request
Jun 1, 2023
(cherry picked from commit 16af3e6) # Conflicts: # package.json # src/plugins/embeddable/public/lib/attribute_service/attribute_service.tsx # x-pack/plugins/canvas/public/components/workpad_header/editor_menu/editor_menu.tsx # x-pack/plugins/security_solution/public/management/pages/policy/store/policy_details/middleware/policy_trusted_apps_middleware.ts
mistic
added a commit
that referenced
this pull request
Jun 1, 2023
# Backport This will backport the following commits from `main` to `7.17`: - [[TypeScript] Upgrade to 4.5.3 (#120812)](#120812) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Brian Seeders","email":"brian.seeders@elastic.co"},"sourceCommit":{"committedDate":"2021-12-13T17:54:17Z","message":"[TypeScript] Upgrade to 4.5.3 (#120812)","sha":"16af3e612d27bd3608787a3daab121d648787f67","branchLabelMapping":{"^v8.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","Feature:Embedding","Team:APM","release_note:skip","Feature:CI","backport:skip","Team:Fleet","v8.1.0"],"number":120812,"url":"https://github.com/elastic/kibana/pull/120812","mergeCommit":{"message":"[TypeScript] Upgrade to 4.5.3 (#120812)","sha":"16af3e612d27bd3608787a3daab121d648787f67"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.1.0","labelRegex":"^v8.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/120812","number":120812,"mergeCommit":{"message":"[TypeScript] Upgrade to 4.5.3 (#120812)","sha":"16af3e612d27bd3608787a3daab121d648787f67"}}]}] BACKPORT--> Co-authored-by: Brian Seeders <brian.seeders@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades TypeScript to the latest version.
See #121003 for the
isEditableissue