Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] remove legacy csv export type #121435

Merged
merged 19 commits into from
Dec 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 1 addition & 32 deletions x-pack/plugins/reporting/README.md
Original file line number Diff line number Diff line change
@@ -1,34 +1,3 @@
# Kibana Reporting

An awesome Kibana reporting plugin

# Development

Assuming you've checked out x-plugins next to kibana...

- Run `yarn kbn bootstrap`
- Run `yarn start` to watch for and sync files on change
- Open a new terminal to run Kibana - use `yarn start` to launch it in dev mode
- Kibana will automatically restart as files are synced
- If you need debugging output, run `DEBUG=reporting yarn start` instead

If you have installed this somewhere other than via x-plugins, and next to the kibana repo, you'll need to change the `pathToKibana` setting in `gulpfile.js`

# Conventions

This plugins adopts some conventions in addition to or in place of conventions in Kibana (at the time of the plugin's creation):

## Folder structure
```
export_types/ (contains public and server aspects of the different export types)
printable_pdf/
public/
server/
csv/
public/
server/
public/ (shared public code for all export types)
server/ (shared server code for all export types)
```

This folder structure treats the different export_types like Plugins, with their public/server code being separate in a folder.
An awesome Kibana reporting plugin
63 changes: 0 additions & 63 deletions x-pack/plugins/reporting/common/types/export_types/csv.ts

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,3 @@ export interface TaskPayloadPDF extends BasePayload {
forceNow?: string;
objects: Array<{ relativeUrl: string }>;
}

export interface JobParamsPDFLegacy extends Omit<JobParamsPDF, 'relativeUrls'> {
savedObjectId: string;
queryString: string;
}
24 changes: 0 additions & 24 deletions x-pack/plugins/reporting/server/export_types/csv/create_job.ts

This file was deleted.

Loading