[Fleet] Add validation test for openApi files #121544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criamico
added
v8.0.0
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
criamico
force-pushed
the
jest_validate_openapi
branch
from
f4bd859
to
47aae70
Compare
nchaulet
approved these changes
Dec 17, 2021
|
nice improvement! |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @criamico |
tylersmalley
approved these changes
Dec 21, 2021
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 21, 2021
* [Fleet] Add validation test for openApi files * Fix missing types declaration * Fix licence issue Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Dec 21, 2021
* [Fleet] Add validation test for openApi files * Fix missing types declaration * Fix licence issue Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Cristina Amico <criamico@users.noreply.github.com>
gbamparop
pushed a commit
to gbamparop/kibana
that referenced
this pull request
Jan 12, 2022
* [Fleet] Add validation test for openApi files * Fix missing types declaration * Fix licence issue Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
azasypkin
added a commit
to azasypkin/kibana
that referenced
this pull request
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a test to jest to validating openApi docs. It uses swagger-parser which is the library used by swagger-cli.
Repro steps
node scripts/jest -c x-pack/plugins/fleet/jest.config.js -i x-pack/plugins/fleet/common/openapi/validate_docs.test.ts. The test should fail.For maintainers