-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Osquery] Add telemetry for packs and saved queries #122501
[Osquery] Add telemetry for packs and saved queries #122501
Conversation
…lemetry # Conflicts: # x-pack/plugins/osquery/kibana.json
Pinging @elastic/security-asset-management (Team:Asset Management) |
@afharo would you mind taking a look at this PR again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌔 🚀 ✨ LGTM ✨ 🚀 🌔
Looks good from a security telemetry pov. Thanks for all the hard work you put into this
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build SucceededMetrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
(cherry picked from commit 259d1b7)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Summary
Collecting telemetry of live queries.
Took it from #115180
See
sender.ts
To test:
Run live query
For event sender:
Add to
kibana.dev.yml
to opt in telemetry and see debug logs:In case of success/failure of upgrades, the debug log should include events sent to telemetry v3 endpoint.