re-render react component when vis.params are updated #12347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
added a commit
that referenced
this pull request
Jun 26, 2017
fixing tests fixing tsvb auto apply button fix tsvb resizing issue update scope.$apply for react editor components re-render react component when vis.params are updated (#12347) fixing heatmap remove obsolete maps_renderbot indirection remove cruft/ remove custom resizing and hook into global event fixing brush event fixing resize event for vislib_vis_type fixing legend changing based on nathans review
ppisljar
added a commit
that referenced
this pull request
Jun 29, 2017
fixing tests fixing tsvb auto apply button fix tsvb resizing issue update scope.$apply for react editor components re-render react component when vis.params are updated (#12347) fixing heatmap remove obsolete maps_renderbot indirection remove cruft/ remove custom resizing and hook into global event fixing brush event fixing resize event for vislib_vis_type fixing legend changing based on nathans review
thomasneirynck
pushed a commit
that referenced
this pull request
Jul 4, 2017
fixing tests fixing tsvb auto apply button fix tsvb resizing issue update scope.$apply for react editor components re-render react component when vis.params are updated (#12347) fixing heatmap remove obsolete maps_renderbot indirection remove cruft/ remove custom resizing and hook into global event fixing brush event fixing resize event for vislib_vis_type fixing legend changing based on nathans review
ppisljar
added a commit
that referenced
this pull request
Jul 7, 2017
fixing tests fixing tsvb auto apply button fix tsvb resizing issue update scope.$apply for react editor components re-render react component when vis.params are updated (#12347) fixing heatmap remove obsolete maps_renderbot indirection remove cruft/ remove custom resizing and hook into global event fixing brush event fixing resize event for vislib_vis_type fixing legend changing based on nathans review
ppisljar
added a commit
that referenced
this pull request
Jul 7, 2017
* converting Vis to es6 class * <visualize>, <visualization> and <visualization-editor> * editor, responseHandler and requestHandler registries * updating visualize editor app * vis, default editor, request handlers and vis types * updating vis types * updating kibana to work with new visualize * migrating existing visualizations * fixing bugs with rebase fixing tests fixing tsvb auto apply button fix tsvb resizing issue update scope.$apply for react editor components re-render react component when vis.params are updated (#12347) fixing heatmap remove obsolete maps_renderbot indirection remove cruft/ remove custom resizing and hook into global event fixing brush event fixing resize event for vislib_vis_type fixing legend changing based on nathans review * fixing tests * fixing renderComplete issues with editor * map updates * fixing maps zoom * fixing based on nathans review * fixing render complete issue and doulbe rendering with maps * trying to get maps in order .... wip * removing resize method from visualizations * changing the rendering process a bit * fixing metric chart type auto changing * minor simplifications in coordinate map viz * more simplications now we only have single render * minor fixes * do not recreate layer when not necessary * minor changes * fixing maps bounding box filter * fixing desaturation option * fix zoom settings when toggling between WMS/basemap * adding status to the render method (to figure out what changed) * fixing legend open icon going out of page * skip index selection for timelion * timelion brush fix * fixing circular json issue * fix faulty rebase * fixing updateStatus * removing timelion requesthandler registration * removing double slash * fixing maps * add debug statement * test CI with guard statement * fixing rebase
thomasneirynck
pushed a commit
that referenced
this pull request
Jul 7, 2017
fixing tests fixing tsvb auto apply button fix tsvb resizing issue update scope.$apply for react editor components re-render react component when vis.params are updated (#12347) fixing heatmap remove obsolete maps_renderbot indirection remove cruft/ remove custom resizing and hook into global event fixing brush event fixing resize event for vislib_vis_type fixing legend changing based on nathans review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stageEditorParamsreally helps, thanks. Now react editors can be stateless!!! - with the state being managed by vis_options. The only missing link is to re-render the component when the state changes. This PR fixes that.If you are worried about performance, it should not be a problem. ngReact does the same thing. Any time the props change, ngReact calls render again.For more information about re-rendering react components.