Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Re-enable useLatestPackageVersion option for integration edit custom UI #123783

Merged
merged 2 commits into from
Jan 26, 2022
Merged

[APM] Re-enable useLatestPackageVersion option for integration edit custom UI #123783

merged 2 commits into from
Jan 26, 2022

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented Jan 26, 2022

Closes #123782

@ogupte ogupte added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed labels Jan 26, 2022
@ogupte ogupte requested a review from a team as a code owner January 26, 2022 01:52
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Jan 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@ogupte
Copy link
Contributor Author

ogupte commented Jan 26, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

dgieselaar
dgieselaar approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admittedly don't really know what the consequences are of this change, but I'll also assume that you'll know best given your expertise here 😄

@ogupte
Copy link
Contributor Author

ogupte commented Jan 26, 2022

I admittedly don't really know what the consequences are of this change, but I'll also assume that you'll know best given your expertise here 😄

Just keeping it in sync with 7.16 and 7.17, we set it to false in the later version to workaround a bug with the intention to re-enabled it once the bug was fixed.

@ogupte ogupte merged commit e45c352 into elastic:main Jan 26, 2022
@kibanamachine
Copy link
Contributor

The following labels were identified as gaps in your version labels and will be added automatically:

  • v8.1.0

If any of these should not be on your pull request, please manually remove them.

@kibanamachine kibanamachine mentioned this pull request Jan 26, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 26, 2022
@ogupte @kibanamachine
[APM] Re-enable useLatestPackageVersion option for integration edit c…
02cd18f 
…ustom UI (elastic#123782) (elastic#123783)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit e45c352)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.0

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 26, 2022
@kibanamachine @ogupte
[APM] Re-enable useLatestPackageVersion option for integration edit c…
4ff638c 
…ustom UI (#123782) (#123783) (#123822)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit e45c352)

Co-authored-by: Oliver Gupte <ogupte@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v8.0.0 v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Re-enable useLatestPackageVersion option for integration edit custom UI
5 participants
@ogupte @elasticmachine @kibana-ci @kibanamachine @dgieselaar