Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add missing reporting config #123917

Merged
merged 6 commits into from
Jan 31, 2022
Merged

[Docs] Add missing reporting config #123917

merged 6 commits into from
Jan 31, 2022

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Jan 27, 2022 •
edited
Loading

Summary

Closes #113844
Closes #120851

This PR adds documentation for:

  • xpack.reporting.csv.escapeFormulaValues
  • xpack.reporting.csv.useByteOrderMarkEncoding

Screenshot 2022-01-27 at 13 26 28

Checklist

@jloleysens jloleysens added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes Team:Reporting Services v8.1.0 v8.2.0 v8.0.1 labels Jan 27, 2022
@jloleysens jloleysens requested review from a team as code owners January 27, 2022 12:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

KOTungseth
KOTungseth approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

dokmic
dokmic approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@dokmic dokmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
data 2771 2770 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 54895a2 into elastic:main Jan 31, 2022
@jloleysens jloleysens deleted the docs/add-missing-reporting-config branch January 31, 2022 14:24
@jloleysens jloleysens mentioned this pull request Feb 1, 2022
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 1, 2022
@jloleysens
[Docs] Add missing reporting config (elastic#123917)
2acc12e 
* added docs for `xpack.reporting.csv.escapeFormulaValues` config and `xpack.reporting.csv.useByteOrderMarkEncoding`, and some minor auto-formatting

* some more auto-formatting changes

* addded some documentation to CSV escape function

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 54895a2)
jloleysens added a commit that referenced this pull request Feb 1, 2022
@jloleysens
[Docs] Add missing reporting config (#123917) (#124270)
1fd8c41 
* added docs for `xpack.reporting.csv.escapeFormulaValues` config and `xpack.reporting.csv.useByteOrderMarkEncoding`, and some minor auto-formatting

* some more auto-formatting changes

* addded some documentation to CSV escape function

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 54895a2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokmic dokmic dokmic approved these changes

@KOTungseth KOTungseth KOTungseth approved these changes

@vadimkibana vadimkibana vadimkibana approved these changes

@tsullivan tsullivan Awaiting requested review from tsullivan

Assignees
No one assigned
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v8.0.1 v8.1.0 v8.2.0
Projects
None yet
Milestone
No milestone
7 participants
@jloleysens @elasticmachine @kibana-ci @dokmic @KOTungseth @vadimkibana @kibanamachine