Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Line styles form adapted to the new design #125955

Merged
merged 1 commit into from
Feb 24, 2022
Merged

[Lens] Line styles form adapted to the new design #125955

merged 1 commit into from
Feb 24, 2022

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Feb 17, 2022 •
edited
Loading

Needs to wait for #125651 ✅ and #125023 ✅ to be merged

Before:
Screenshot 2022-02-17 at 17 56 44

After:
Screenshot 2022-02-24 at 09 09 44

@mbondyra mbondyra added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.2.0 labels Feb 17, 2022
@elastic elastic deleted a comment from kibana-ci Feb 17, 2022
@mbondyra mbondyra force-pushed the lens/line_styles_changed branch 2 times, most recently from bb87de7 to a1a6a4f Compare February 24, 2022 08:05
@mbondyra mbondyra marked this pull request as ready for review February 24, 2022 08:10
@mbondyra mbondyra requested a review from a team as a code owner February 24, 2022 08:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

dej611
dej611 approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with Safari 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.1MB 1.1MB +46.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mbondyra mbondyra merged commit 6b5fb28 into elastic:main Feb 24, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125955 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 28, 2022
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125955 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 125955 or prevent reminders by adding the backport:skip label.

@stratoula stratoula added backport:skip This commit does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Mar 2, 2022
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@mbondyra @lucasfcosta
[Lens] change line styles waiting for eui upgrade (elastic#125955)
9c20f04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mbondyra @elasticmachine @kibana-ci @kibanamachine @dej611 @stratoula