Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Move error_code to output #126044

Merged
merged 11 commits into from
Feb 24, 2022
Merged

[Reporting] Move error_code to output #126044

merged 11 commits into from
Feb 24, 2022

Conversation

jloleysens
Copy link
Contributor

Summary

Per the title. Also added a small integration test to confirm that the error_code field is populated where we expect it to be.

Checklist

@jloleysens jloleysens added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes Team:Reporting Services v8.2.0 labels Feb 21, 2022
@jloleysens jloleysens requested review from a team as code owners February 21, 2022 09:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

tsullivan
tsullivan approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@tsullivan
Copy link
Member

@elasticmachine merge upstream

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens added the backport:skip This commit does not require backporting label Feb 24, 2022
@jloleysens jloleysens merged commit 322436a into elastic:main Feb 24, 2022
@jloleysens jloleysens deleted the reporting/move-error-codes-to-output branch February 24, 2022 10:26
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@jloleysens @kibanamachine @lucasfcosta
[Reporting] Move error_code to output (elastic#126044)
9037839 
* move error_code to output

* first version of api integration test for error_code

* clean up old error_code field and make exisint one optional

* use correct mapping format

* fix api integration test

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jloleysens @elasticmachine @tsullivan @kibana-ci @kibanamachine