Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] [ResponseOps] Adds tooltip to time window selector in ES query rule flyout (#125764) #126051

Merged
merged 1 commit into from
Feb 21, 2022
+27 −7
Merged

[8.0] [ResponseOps] Adds tooltip to time window selector in ES query rule flyout (#125764) #126051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions x-pack/plugins/stack_alerts/public/alert_types/es_query/expression.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import 'brace/theme/github';
import { XJsonMode } from '@kbn/ace';

import {
EuiFlexGroup,
EuiFlexItem,
EuiButtonEmpty,
EuiCodeEditor,
EuiSpacer,
Expand All @@ -21,6 +23,7 @@ import {
EuiText,
EuiTitle,
EuiLink,
EuiIconTip,
} from '@elastic/eui';
import { DocLinksStart, HttpSetup } from 'kibana/public';
import type * as estypes from '@elastic/elasticsearch/lib/api/typesWithBodyKey';
Expand Down Expand Up @@ -348,14 +351,31 @@ export const EsQueryAlertTypeExpression: React.FunctionComponent<
</EuiFormRow>
)}
<EuiSpacer />
<EuiTitle size="xs">
<h5>
<FormattedMessage
id="xpack.stackAlerts.esQuery.ui.conditionPrompt"
defaultMessage="When number of matches"
<EuiFlexGroup alignItems="center" responsive={false} gutterSize="none">
<EuiFlexItem grow={false}>
<EuiTitle size="xs">
<h5>
<FormattedMessage
id="xpack.stackAlerts.esQuery.ui.conditionPrompt"
defaultMessage="When number of matches"
/>
</h5>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiIconTip
position="right"
color="subdued"
type="questionInCircle"
iconProps={{
className: 'eui-alignTop',
}}
content={i18n.translate('xpack.stackAlerts.esQuery.ui.conditionPrompt.toolTip', {
defaultMessage: 'The time window defined below applies only to the first rule check.',
})}
/>
</h5>
</EuiTitle>
</EuiFlexItem>
</EuiFlexGroup>
<EuiSpacer size="s" />
<ThresholdExpression
data-test-subj="thresholdExpression"
Expand Down