-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry] Check permissions when requesting telemetry #126238
Merged
Merged
Changes from 14 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ca98c07
[Telemetry] Include `security` dependency
afharo da5c756
Clean usage collection types (removal of KibanaRequest context extens…
afharo de282e2
Fix premissions usage
afharo 7d4aa84
Remove `home` dependency on `telemetry`
afharo 64f6fd3
Fix types
afharo 0342826
Merge branch 'main' of github.com:elastic/kibana into telemetry-depen…
afharo eea162b
Fix more types and tests
afharo 93aaf41
Fix TS refs (no idea why it failed in this PR)
afharo 543b712
Fix broken tests
afharo 260aa2a
Fix translation files
afharo 35dd344
Remove unused variable
afharo 2a5497b
Fix `home` public API missing export
afharo 6b200bf
Only validate the permissions on unencrypted requests
afharo 5b48f6e
@jportner is our saviour
afharo 738cf14
Merge branch 'main' into telemetry-depending-on-security
kibanamachine effa7f4
Merge branch 'main' into telemetry-depending-on-security
kibanamachine 7f76422
Merge branch 'main' of github.com:elastic/kibana into telemetry-depen…
afharo 6788d62
nit: test 2 different onRendered handlers
afharo 65d7835
nit: Use `file.test.mocks.ts` + `jest.doMock`
afharo 6f7e648
Only allow one telemetry notice renderer
afharo 40578d1
Make `home` dependency optional
afharo 8639532
Use security mock instead of creating our own
afharo b50da6b
Add functional tests
afharo 8802cd8
try/catch externally registered handlers
afharo 90e7bee
Merge branch 'main' of github.com:elastic/kibana into telemetry-depen…
afharo 51b02f0
Fix type check
afharo d15a542
Merge branch 'main' into telemetry-depending-on-security
kibanamachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
196 changes: 0 additions & 196 deletions
196
src/plugins/home/public/application/components/__snapshots__/home.test.tsx.snap
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why it failed in this PR. But
dashboard
is importing types fromscreenshot_mode
and it was missing this line.@elastic/kibana-operations probably a bug in the
type_check
script that didn't catch it earlier inmain
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not totally sure how TypeScript validates that projects have the references they need, it seems to validate it most of the time but there are edge cases where you can import from another project even when it's not listed in the projects deps. We are on the cusp of moving away from relative plugin imports to imported based on global module IDs for packages which will make this a non-problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a strange situation, but I'm glad we'll be moving away from it in the future. Thanks for adding the project to our tsconfig though!