Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse url-parse dependencies #126301

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Collapse url-parse dependencies #126301

merged 1 commit into from
Feb 24, 2022

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Feb 23, 2022 •
edited
Loading

In #126119, we upgraded from url-parse@1.5.3 to url-parse@1.5.9.

Afterwards, url-parse@1.5.6 was accidentally added with #125023.

This PR removes the redundant dependency in favor of url-parse@1.5.9.

Collapse url-parse dependencies
061cd10 
url-parse@1.5.6 was accidentally added with elastic#125023.
This commit removes the redundant dependency in favor of
url-parse@1.5.9.
@jportner jportner added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.2.0 labels Feb 23, 2022
@jportner jportner enabled auto-merge (squash) February 23, 2022 22:54
@jportner jportner requested a review from watson February 23, 2022 22:54
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 4.8MB 4.8MB +99.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner mentioned this pull request Feb 24, 2022
Closed
@jportner jportner merged commit afa9557 into elastic:main Feb 24, 2022
@jportner jportner deleted the fix-url-parse branch February 24, 2022 05:56
lucasfcosta pushed a commit to lucasfcosta/kibana that referenced this pull request Mar 2, 2022
@jportner @lucasfcosta
Collapse url-parse dependencies (elastic#126301)
d1060f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watson watson watson approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jportner @kibana-ci @watson