Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Visualize Refactor (#11786)" #12711

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Revert "Visualize Refactor (#11786)" #12711

merged 1 commit into from
Jul 7, 2017

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Jul 7, 2017 •
edited
Loading

Reverting 3000221 (#11786) due to Xpack breakage. Let's resolve those X-Pack issues first.

  • service_settings module moved location, so Xpack needs to be updated.
  • machine learning plugins need to use the .createAngularVisType factory function instead of the TemplatedVisType constructor, as well as import files from the new locations

@thomasneirynck thomasneirynck merged commit c20a48c into elastic:master Jul 7, 2017
This was referenced Jul 7, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thomasneirynck