Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option for url types so that it can be opened in current tab #13055

Closed
wants to merge 1 commit into from

Conversation

fbaligand
Copy link
Contributor

@fbaligand fbaligand commented Jul 23, 2017

Fix #12668

image

@elasticmachine
Copy link
Contributor

Can one of the admins verify this patch?

@epixa
Copy link
Contributor

epixa commented Jul 26, 2017

@fbaligand Can you open this against master? We'll then handle backporting it to the relevant versions.

Also, we've passed feature freeze for 5.x and 6.0, so the soonest this would be able to go out is 6.1

@fbaligand
Copy link
Contributor Author

fbaligand commented Jul 30, 2017

@epixa
Waou, I'm very surprised that 5.x and 6.0 branches are already freezed...
I'm a little bit sad about it :(

Anyway, I created a new PR based on kibana master : #13209

And like hope is still allowed 😃, I created also a PR for 5.6 and 6.0 branches :

If you wish a PR for 6.x branch, tell me.

Fabien

@epixa
Copy link
Contributor

epixa commented Aug 9, 2017

@fbaligand Thanks for opening up the PR against master. We'll get a review on that asap.

Unfortunately for this case, it is too late to get new features into 5.6 and 6.0. We're working on shoring up and QAing both of those releases so everyone can be confident that they're stable, and even seemingly small features interrupt that process.

@epixa
Copy link
Contributor

epixa commented Aug 9, 2017

Closing this in favor of #13209

@epixa epixa closed this Aug 9, 2017
@fbaligand fbaligand deleted the openLinkInCurrentTab branch September 16, 2017 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants