[Cases] Refactor: Move Case View Page main content to its own component #130666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
academo
added
Team:ResponseOps
academo
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
cnasikas
reviewed
Apr 20, 2022
cnasikas
reviewed
Apr 20, 2022
…lerts-tab-case-view
…lerts-tab-case-view
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @academo |
peteharverson
approved these changes
Apr 25, 2022
| expect(result.getByTestId('case-view-status-action-button')).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should show a loading when initLoadingData is true and hide the user actions activity', () => { |
There was a problem hiding this comment.
Should this read should show a loading indicator... ?
dmlemeshko
pushed a commit
to dmlemeshko/kibana
that referenced
this pull request
May 5, 2022
kertal
pushed a commit
to kertal/kibana
that referenced
this pull request
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses: #116501
First step to introduce a tabbed view in the case view page.
The current case view page component is too large to introduce a tabbed view without making it harder to maintain.
This simple refactor moves all the main content: user activity and sidebar to its own component along with all the required variables and hooks calls.
This PR doesn't affect user functionality or UI in anyway, only moves code around.
Checklist