Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Investigations] [Tech Debt] removes deepEqual checks in column headers and data providers #130740

Merged
merged 2 commits into from
Apr 21, 2022
Merged

[Security Solution] [Investigations] [Tech Debt] removes deepEqual checks in column headers and data providers #130740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
856743a
## [Security Solution] [Investigations] [Tech Debt] removes `deepEqua…
andrew-goldstein Apr 20, 2022
dff43b2
- remove obsolete snapshot
andrew-goldstein Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions ...urity_solution/public/timelines/components/timeline/body/column_headers/column_header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { EuiContextMenu, EuiContextMenuPanelDescriptor, EuiIcon, EuiPopover } fr
import React, { useCallback, useMemo, useRef, useState } from 'react';
import { Draggable } from 'react-beautiful-dnd';
import { Resizable, ResizeCallback } from 're-resizable';
import deepEqual from 'fast-deep-equal';
import { useDispatch } from 'react-redux';
import styled from 'styled-components';
import { DRAGGABLE_KEYBOARD_WRAPPER_CLASS_NAME } from '@kbn/securitysolution-t-grid';
Expand Down Expand Up @@ -298,14 +297,4 @@ const ColumnHeaderComponent: React.FC<ColumneHeaderProps> = ({
);
};

export const ColumnHeader = React.memo(
ColumnHeaderComponent,
(prevProps, nextProps) =>
prevProps.draggableIndex === nextProps.draggableIndex &&
prevProps.tabType === nextProps.tabType &&
prevProps.timelineId === nextProps.timelineId &&
prevProps.isDragging === nextProps.isDragging &&
prevProps.onFilterChange === nextProps.onFilterChange &&
deepEqual(prevProps.sort, nextProps.sort) &&
deepEqual(prevProps.header, nextProps.header)
);
export const ColumnHeader = React.memo(ColumnHeaderComponent);
19 changes: 2 additions & 17 deletions ...gins/security_solution/public/timelines/components/timeline/body/column_headers/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import deepEqual from 'fast-deep-equal';

import React, { useState, useEffect, useCallback, useMemo, useRef } from 'react';
import { Droppable, DraggableChildrenFn } from 'react-beautiful-dnd';

Expand Down Expand Up @@ -312,19 +312,4 @@ export const ColumnHeadersComponent = ({
);
};

export const ColumnHeaders = React.memo(
ColumnHeadersComponent,
(prevProps, nextProps) =>
prevProps.actionsColumnWidth === nextProps.actionsColumnWidth &&
prevProps.isEventViewer === nextProps.isEventViewer &&
prevProps.isSelectAllChecked === nextProps.isSelectAllChecked &&
prevProps.onSelectAll === nextProps.onSelectAll &&
prevProps.show === nextProps.show &&
prevProps.showEventsSelect === nextProps.showEventsSelect &&
prevProps.showSelectAllCheckbox === nextProps.showSelectAllCheckbox &&
deepEqual(prevProps.sort, nextProps.sort) &&
prevProps.timelineId === nextProps.timelineId &&
deepEqual(prevProps.columnHeaders, nextProps.columnHeaders) &&
prevProps.tabType === nextProps.tabType &&
deepEqual(prevProps.browserFields, nextProps.browserFields)
);
export const ColumnHeaders = React.memo(ColumnHeadersComponent);
10 changes: 1 addition & 9 deletions ...ugins/security_solution/public/timelines/components/timeline/data_providers/providers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import React, { useCallback, useMemo, useRef, useState } from 'react';
import { Draggable, DraggingStyle, Droppable, NotDraggingStyle } from 'react-beautiful-dnd';
import styled from 'styled-components';
import { useDispatch } from 'react-redux';
import deepEqual from 'fast-deep-equal';

import {
DRAGGABLE_KEYBOARD_WRAPPER_CLASS_NAME,
Expand Down Expand Up @@ -357,14 +356,7 @@ export const DataProvidersGroupItem = React.memo<DataProvidersGroupItem>(
</Draggable>
</div>
);
},
(prevProps, nextProps) =>
prevProps.groupIndex === nextProps.groupIndex &&
prevProps.index === nextProps.index &&
prevProps.timelineId === nextProps.timelineId &&
deepEqual(prevProps.browserFields, nextProps.browserFields) &&
deepEqual(prevProps.group, nextProps.group) &&
deepEqual(prevProps.dataProvider, nextProps.dataProvider)
}
);

DataProvidersGroupItem.displayName = 'DataProvidersGroupItem';
Expand Down
Loading