Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17] Reduce usage of the trim dependency (#130863) #130896

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

watson
Copy link
Contributor

@watson watson commented Apr 25, 2022

Backport

This will backport the following commits from main to 7.17:

Questions ?

Please refer to the Backport tool documentation

We forcefully upgrade the trim sub-dependency to v1.0.1 because of an
old known security vulnerability. Two of our dependencies who previously
depended on trim no longer does so, and we can therefore now upgrade
those to get rid of the warnings generated because of this forceful
upgrade.

(cherry picked from commit 641fc10)

# Conflicts:
#	yarn.lock
@watson watson enabled auto-merge (squash) April 25, 2022 13:46
@watson watson merged commit 3c371e7 into elastic:7.17 Apr 25, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 5.1MB 5.1MB -5.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@watson watson deleted the backport/7.17/pr-130863 branch April 26, 2022 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants