Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Investigations] [Tech Debt] removes redundant code from the timelines plugin #130928

Merged
merged 1 commit into from
Apr 25, 2022
Merged

[Security Solution] [Investigations] [Tech Debt] removes redundant code from the timelines plugin #130928

merged 1 commit into from
Apr 25, 2022

Conversation

andrew-goldstein
Copy link
Contributor

[Security Solution] [Investigations] [Tech Debt] removes redundant code from the timelines plugin

This follow-up PR removes redundant code from the timelines plugin, identified while implementing #130740

@andrew-goldstein
## [Security Solution] [Investigations] [Tech Debt] removes redundant…
252e10b 
… code from timelines plugin

This follow-up PR removes redundant code from the `timelines` plugin, identified while implementing elastic#130740
@andrew-goldstein andrew-goldstein added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.3.0 labels Apr 25, 2022
@andrew-goldstein andrew-goldstein requested a review from a team as a code owner April 25, 2022 20:11
@andrew-goldstein andrew-goldstein self-assigned this Apr 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

kqualters-elastic
kqualters-elastic approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 10/10 pr

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
timelines 270 265 -5

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
timelines 282.1KB 275.9KB -6.1KB
Unknown metric groups

ESLint disabled line counts

id before after diff
timelines 43 41 -2

Total ESLint disabled count

id before after diff
timelines 45 43 -2

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @andrew-goldstein

@andrew-goldstein andrew-goldstein merged commit 3ad6452 into elastic:main Apr 25, 2022
@andrew-goldstein andrew-goldstein deleted the delete-redundant-timelines branch April 25, 2022 22:15
YulNaumenko
YulNaumenko reviewed Apr 25, 2022
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@janmonschke
Copy link
Contributor

I'm late to the party but 🎉 🎉 🎉

dmlemeshko pushed a commit to dmlemeshko/kibana that referenced this pull request May 5, 2022
@andrew-goldstein @dmlemeshko
[Security Solution] [Investigations] [Tech Debt] removes redundant co…
ab4775c 
…de from timelines plugin (elastic#130928)

## [Security Solution] [Investigations] [Tech Debt] removes redundant code from the timelines plugin

This follow-up PR removes redundant code from the `timelines` plugin, identified while implementing elastic#130740
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@andrew-goldstein @kertal
[Security Solution] [Investigations] [Tech Debt] removes redundant co…
1d92a14 
…de from timelines plugin (elastic#130928)

## [Security Solution] [Investigations] [Tech Debt] removes redundant code from the timelines plugin

This follow-up PR removes redundant code from the `timelines` plugin, identified while implementing elastic#130740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko left review comments

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

Assignees

@andrew-goldstein andrew-goldstein

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andrew-goldstein @elasticmachine @kibana-ci @janmonschke @YulNaumenko @kqualters-elastic