Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Remove deprecated api (index pattern) usage #130949

Merged
merged 4 commits into from
Apr 26, 2022

Conversation

shahzad31
Copy link
Contributor

Summary

Update usage of deprecated API as per elastic/uptime#449

@shahzad31 shahzad31 requested a review from a team as a code owner April 26, 2022 08:37
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels Apr 26, 2022
@@ -124,7 +124,7 @@ const Application = (props: UptimeAppProps) => {
<UptimeSettingsContextProvider {...props}>
<UptimeThemeContextProvider darkMode={darkMode}>
<UptimeStartupPluginsContextProvider {...startPlugins}>
<UptimeIndexPatternContextProvider data={startPlugins.data}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename the file x-pack/plugins/uptime/public/contexts/uptime_index_pattern_context.tsx to match the data_view name too?

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 787.3KB 787.3KB +9.0B
Unknown metric groups

References to deprecated APIs

id before after diff
synthetics 34 8 -26

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit b013b96 into elastic:main Apr 26, 2022
@shahzad31 shahzad31 deleted the uptime-data-view branch April 26, 2022 10:40
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 26, 2022
dmlemeshko pushed a commit to dmlemeshko/kibana that referenced this pull request May 5, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants