Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ux app, remove deprecated api usage #130952

Merged
merged 2 commits into from
Apr 26, 2022
Merged

ux app, remove deprecated api usage #130952

merged 2 commits into from
Apr 26, 2022

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Apr 26, 2022 •
edited
Loading

Summary

As part of elastic/uptime#449 remove usage of deprecated api

@shahzad31 shahzad31 marked this pull request as ready for review April 26, 2022 10:03
@shahzad31 shahzad31 requested a review from a team as a code owner April 26, 2022 10:03
@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.3.0 labels Apr 26, 2022
lucasfcosta
lucasfcosta approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@lucasfcosta lucasfcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@shahzad31 shahzad31 enabled auto-merge (squash) April 26, 2022 10:41
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ux 170.2KB 170.2KB +17.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit f8d0a2f into elastic:main Apr 26, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 26, 2022
@shahzad31 shahzad31 deleted the ux-data-view branch April 26, 2022 11:18
@shahzad31 shahzad31 mentioned this pull request Apr 26, 2022
Closed
dmlemeshko pushed a commit to dmlemeshko/kibana that referenced this pull request May 5, 2022
@shahzad31 @dmlemeshko
ux app, remove deprecated api usage (elastic#130952)
171e8f0 
* ux app, remove deprecated api usage

* update
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@shahzad31 @kertal
ux app, remove deprecated api usage (elastic#130952)
f6482a6 
* ux app, remove deprecated api usage

* update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasfcosta lucasfcosta lucasfcosta approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shahzad31 @kibana-ci @lucasfcosta @kibanamachine