Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EBT] Remove unnecessary async from tests #131500

Merged
merged 1 commit into from
May 4, 2022
Merged

[EBT] Remove unnecessary async from tests #131500

merged 1 commit into from
May 4, 2022

Conversation

afharo
Copy link
Member

@afharo afharo commented May 4, 2022

Summary

Follow up to #131494 to address the NIT.

For maintainers

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.3.0 labels May 4, 2022
@afharo afharo requested a review from a team as a code owner May 4, 2022 10:37
gsoldevila
gsoldevila approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@gsoldevila gsoldevila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@afharo afharo enabled auto-merge (squash) May 4, 2022 10:38
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit 8271455 into elastic:main May 4, 2022
@afharo afharo deleted the ebt/analytics-remove-unnecessary-async branch May 4, 2022 11:44
dmlemeshko pushed a commit to dmlemeshko/kibana that referenced this pull request May 5, 2022
@afharo @dmlemeshko
[EBT] Remove unnecessary async from tests (elastic#131500)
fc51ec8
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
@afharo @kertal
[EBT] Remove unnecessary async from tests (elastic#131500)
7c4c596
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsoldevila gsoldevila gsoldevila approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afharo @kibana-ci @gsoldevila