Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FullStory] Document browser exposed config in the test #131527

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented May 4, 2022

Summary

Follow up to #131148 to address NIT comment.

For maintainers

@afharo afharo added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.3.0 labels May 4, 2022
@afharo afharo requested a review from a team as a code owner May 4, 2022 14:07
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the comment!

@@ -165,6 +165,7 @@ export default function ({ getService }: PluginFunctionalProviderContext) {
'xpack.cloud.deployment_url (string)',
'xpack.cloud.full_story.enabled (boolean)',
'xpack.cloud.full_story.org_id (any)',
// No PII. Just the list of event types we want to forward to FullStory.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: just for my own education (noob in FullStory) - are these just arbitrary strings, or Full Story has a predefined list of these events.

Copy link
Member Author

@afharo afharo May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These strings are not mandated by FullStory. This config is used to filter the events from EBT that we actually want to send to FullStory. It has a very aggressive rate limiting policy regarding custom events (up to 10 events per second and 30 per minute), so we want to send only the events from Kibana that we really want to have in FullStory. All the events will still go to our Remote Telemetry Service, it's just a filter to the FullStory endpoint.

Right now it's just ['Loaded Kibana'] because it's the only event we used to send to FullStory from the start. It may grow to match the name of the events we want to forward.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks for the detailed explanation.

@afharo afharo enabled auto-merge (squash) May 4, 2022 15:05
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit 5f06375 into elastic:main May 4, 2022
@afharo afharo deleted the ebt/fullstory-allowlist-test-documentation branch May 4, 2022 15:15
dmlemeshko pushed a commit to dmlemeshko/kibana that referenced this pull request May 5, 2022
kertal pushed a commit to kertal/kibana that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants