Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Error messages not centered #133288

Merged
merged 1 commit into from
Jun 3, 2022
Merged

[TSVB] Error messages not centered #133288

merged 1 commit into from
Jun 3, 2022

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jun 1, 2022 •
edited
Loading

Summary

The new version of Eui wraps the content of EuiEmptyPrompt in an additional Panel, which was not the case before

image

In TSVB, after that, the error message is no longer centered vertically

Removing flex-direction: column; solves this problem. I tested other visualizations, everything seems to work correctly

After:

image

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
visualizations 287.7KB 287.6KB -44.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp self-assigned this Jun 1, 2022
@alexwizp alexwizp added v8.4.0 release_note:fix Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jun 1, 2022
@alexwizp alexwizp requested a review from a team June 1, 2022 12:46
@alexwizp alexwizp marked this pull request as ready for review June 1, 2022 12:46
@alexwizp alexwizp requested a review from a team as a code owner June 1, 2022 12:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@alexwizp alexwizp mentioned this pull request Jun 1, 2022
Merged
VladLasitsa
VladLasitsa approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@VladLasitsa VladLasitsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

flash1293
flash1293 approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp alexwizp merged commit 036b5ed into elastic:main Jun 3, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 3, 2022
mibragimov pushed a commit to mibragimov/kibana that referenced this pull request Jun 7, 2022
@alexwizp
[TSVB] Error messages not centered (elastic#133288)
dead6cd
@flash1293 flash1293 mentioned this pull request Oct 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@VladLasitsa VladLasitsa VladLasitsa approved these changes

Assignees

@alexwizp alexwizp

Labels
backport:skip This commit does not require backporting Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alexwizp @kibana-ci @elasticmachine @flash1293 @MichaelMarcialis @VladLasitsa @kibanamachine