Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Osquery] Fix for osquery pagination in alert flyout #133595

Merged
merged 2 commits into from
Jun 7, 2022
Merged

[Osquery] Fix for osquery pagination in alert flyout #133595

merged 2 commits into from
Jun 7, 2022

Conversation

tomsonpl
Copy link
Contributor

@tomsonpl tomsonpl commented Jun 6, 2022

Summary

This PR solves a few issues for the 8.3 release:

  • Alert Osquery Flyout issue _id of undefined when changing ''number per row'' .

@tomsonpl tomsonpl self-assigned this Jun 6, 2022
@tomsonpl tomsonpl added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Asset Management Security Asset Management Team Feature:Osquery Security Solution Osquery feature v8.3.0 labels Jun 6, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
osquery 1.0MB 1.0MB +38.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tomsonpl

@tomsonpl tomsonpl marked this pull request as ready for review June 7, 2022 06:36
@tomsonpl tomsonpl requested a review from a team as a code owner June 7, 2022 06:36
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-asset-management (Team:Asset Management)

@tomsonpl tomsonpl changed the title [Osquery] Fixes to 8.3 [Osquery] Fix for osquery pagination in alert flyout Jun 7, 2022
@tomsonpl tomsonpl added v8.4.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 7, 2022
patrykkopycinski
patrykkopycinski approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomsonpl tomsonpl merged commit f1e4c0c into elastic:main Jun 7, 2022
@tomsonpl tomsonpl deleted the fix-osquery-8.3 branch June 7, 2022 06:57
@kibanamachine kibanamachine mentioned this pull request Jun 7, 2022
Merged
kibanamachine pushed a commit that referenced this pull request Jun 7, 2022
@tomsonpl
[Osquery] Add optional chaining to prevent ui error (#133595)
022ac5e 
(cherry picked from commit f1e4c0c)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 9, 2022
kibanamachine added a commit that referenced this pull request Jun 9, 2022
@kibanamachine @tomsonpl
[8.3] [Osquery] Add optional chaining to prevent ui error (#133595) (#…
75d6865 
…133700)

* [Osquery] Add optional chaining to prevent ui error (#133595)

(cherry picked from commit f1e4c0c)

* fix integration test

Co-authored-by: Tomasz Ciecierski <ciecierskitomek@gmail.com>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees

@tomsonpl tomsonpl

Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience Feature:Osquery Security Solution Osquery feature release_note:skip Skip the PR/issue when compiling release notes Team:Asset Management Security Asset Management Team v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tomsonpl @kibana-ci @elasticmachine @kibanamachine @patrykkopycinski