Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] fix policy preselect for non fleet server policy #133711

Merged
merged 1 commit into from
Jun 7, 2022
Merged

[Fleet] fix policy preselect for non fleet server policy #133711

merged 1 commit into from
Jun 7, 2022

Conversation

juliaElastic
Copy link
Contributor

Summary

Fix #131121

To verify:

  • test in cloud or on prem:
  • create a preconfigured managed fleet server policy
  • enroll a fleet server to it
  • create a non fleet server policy
  • open Add agent flyout
  • verify that non fleet server policy is preselected
  • policy is not preselected if it has fleet server integration
Screen.Recording.2022-06-07.at.10.54.09.mov

@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.3.0 v8.4.0 labels Jun 7, 2022
@juliaElastic juliaElastic self-assigned this Jun 7, 2022
@juliaElastic juliaElastic requested a review from a team as a code owner June 7, 2022 08:55
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jun 7, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

criamico
criamico approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliaElastic juliaElastic enabled auto-merge (squash) June 7, 2022 09:04
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #32 / analytics instrumented events from the browser General "click" "before each" hook for "should emit a "click" event"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 751.3KB 751.4KB +100.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @juliaElastic

@juliaElastic juliaElastic merged commit 6014b1e into elastic:main Jun 7, 2022
kibanamachine pushed a commit that referenced this pull request Jun 7, 2022
@juliaElastic
fix policy preselect (#133711)
b465c26 
(cherry picked from commit 6014b1e)
@kibanamachine kibanamachine mentioned this pull request Jun 7, 2022
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 7, 2022
@kibanamachine @juliaElastic
fix policy preselect (#133711) (#133726)
6d5a4f0 
(cherry picked from commit 6014b1e)

Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@criamico criamico criamico approved these changes

Assignees

@juliaElastic juliaElastic

Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.3.0 v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fleet]: Policy is not selected under Add agent flyout when only one policy exists.
5 participants
@juliaElastic @elasticmachine @kibana-ci @kibanamachine @criamico