[chrome/nav/lastUrl] do not track redirect routes #13432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this failure un-related? |
|
Yeah, jenkins test this again please |
|
Sounds unrelated. If it passes this time, file an issue and I'll take a look to see what can be done. |
|
Appears to have failed with a different error now. Here are the previous failures: https://kibana-ci.elastic.co/job/elastic+kibana+pull-request+multijob-selenium/6605 Jenkins, test it |
|
@stacey-gammon created issue #13455 |
tylersmalley
approved these changes
Aug 10, 2017
|
Failed this time on: |
spalger
force-pushed
the
fix/redirects-as-last-url
branch
from
1095569
to
41092b3
Compare
|
@stacey-gammon @tylersmalley looks like there was an actual bug; the kbnChrome directive was assuming that the ngRoute module was included, which is an opt-in feature for apps and not enabled in apps like the status page. |
stacey-gammon
approved these changes
Aug 21, 2017
tylersmalley
approved these changes
Aug 21, 2017
spalger
added a commit
that referenced
this pull request
Aug 22, 2017
* [chrome/nav/lastUrl] do not track redirect routes * [chrome/subUrl] always track subUrl when no router (cherry picked from commit 9a34992)
spalger
added a commit
that referenced
this pull request
Aug 22, 2017
* [chrome/nav/lastUrl] do not track redirect routes * [chrome/subUrl] always track subUrl when no router (cherry picked from commit 9a34992)
spalger
added a commit
that referenced
this pull request
Aug 22, 2017
* [chrome/nav/lastUrl] do not track redirect routes * [chrome/subUrl] always track subUrl when no router (cherry picked from commit 9a34992)
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Nov 20, 2017
* [chrome/nav/lastUrl] do not track redirect routes * [chrome/subUrl] always track subUrl when no router
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Dec 1, 2017
* [chrome/nav/lastUrl] do not track redirect routes * [chrome/subUrl] always track subUrl when no router
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12933
Summary:
When you navigate to a URL that Kibana doesn't recognize it tries to be helpful and send you to discover. At the same time it tries to remember the URL you were last using in each app and bring back where you left off when you come back. Unfortunately, these two features recently collided. If you somehow ended up at an unknown URL that looked like the URL for an app other than discover Kibana would get confused and remember the bad URL and immediately redirect you to discover. If you didn't give up right away you would probably try to go back to the app, but since it Kibana is trying to be helpful it would send you right back to the bad URL and then back to discover... Stupid right?! Well, it won't happen anymore!
The chrome currently updates the
lastUrlof each app whenever there is a navigation, even if the matched route is just redirecting users elsewhere. I can't think if a time that tracking the url of a redirect as thelastUrlof an app would be desired, so this just filters out such navigation events.