[UI Framework] Add KuiOutsideClickDetector #13521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
Team:Platform-Design
zinckiwi
reviewed
Aug 21, 2017
| }, | ||
| }); | ||
|
|
||
| return cloneElement(this.props.children, props); |
There was a problem hiding this comment.
Whoops, sorry for missing the review request on this one. Looks good, though I think
return React.Children.only(this.props.children, child => cloneElement(child, props));
is still the best practice here (even if only for clearer error messaging to a future dev trying to use multiple children).
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Aug 21, 2017
* Add KuiOutsideClickDetector. * Convert KuiColorPicker and KuiPopover to use KuiOutsideClickDetector.
cjcenizal
added a commit
that referenced
this pull request
Aug 21, 2017
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Nov 20, 2017
* Add KuiOutsideClickDetector. * Convert KuiColorPicker and KuiPopover to use KuiOutsideClickDetector.
chrisronline
pushed a commit
to chrisronline/kibana
that referenced
this pull request
Dec 1, 2017
* Add KuiOutsideClickDetector. * Convert KuiColorPicker and KuiPopover to use KuiOutsideClickDetector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13414
Inspired by https://github.com/elastic/kibana/pull/13383/files#diff-d92aa0fe7c9d4339904684fb15395a47R14