Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

savedObjectTagging: use importExport instead of esArchiver for FTR tests #135679

Merged
merged 4 commits into from
Jul 5, 2022
Merged

savedObjectTagging: use importExport instead of esArchiver for FTR tests #135679

merged 4 commits into from
Jul 5, 2022

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Jul 5, 2022 •
edited
Loading

Summary

Adapt the SOT FTR dataset to use kibanaServer.importExport instead of esArchiver, to address to failures related to the esArchiver flakiness.

Fix #133336
Fix #133337
Fix #135347
Fix #135348
Fix #90578
Fix #115320
Fix #135708
Fix #135709

@pgayvallet pgayvallet added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc release_note:skip Skip the PR/issue when compiling release notes v8.4.0 labels Jul 5, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet marked this pull request as ready for review July 5, 2022 13:06
@pgayvallet pgayvallet requested a review from a team as a code owner July 5, 2022 13:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

rudolf
rudolf approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@rudolf rudolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@pgayvallet pgayvallet merged commit dc78287 into elastic:main Jul 5, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 5, 2022
@spalger
Copy link
Contributor

spalger commented Jul 5, 2022

esArchiver flakiness

Excuse me! 😝

@pgayvallet
Copy link
Contributor Author

My deepest apologies @spalger

esArchiver flakiness features

Do you feel better now 😅 ?

@pgayvallet pgayvallet mentioned this pull request Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolf rudolf rudolf approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/bulk_actions·ts - saved objects tagging - functional tests table bulk actions "before each" hook for "deletes multiple tags" Failing test: X-Pack Saved Object Tagging API Integration Tests - Security and Spaces integration.x-pack/test/saved_object_tagging/api_integration/security_and_spaces/apis/get·ts - saved objects tagging API - security and spaces integration GET /api/saved_objects_tagging/tags/{id} "after all" hook for "returns expected 403 response for a_kibana_rbac_default_space_advanced_settings_read_user" Failing test: X-Pack Saved Object Tagging API Integration Tests - Security and Spaces integration.x-pack/test/saved_object_tagging/api_integration/security_and_spaces/apis/get·ts - saved objects tagging API - security and spaces integration GET /api/saved_objects_tagging/tags/{id} "before all" hook for "returns expected 200 response for superuser" Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/som_integration·ts - saved objects tagging - functional tests saved objects management integration navigating from the tag section access the saved objects management section with pre-applied filter Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/listing·ts - saved objects tagging - functional tests table listing "before all" hook in "table listing"
Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/bulk_actions·ts - saved objects tagging - functional tests table bulk actions "after each" hook for "deletes multiple tags" Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/bulk_assign·ts - saved objects tagging - functional tests bulk assign "before each" hook for "can bulk assign tags to objects" Failing test: X-Pack Saved Object Tagging Functional Tests.x-pack/test/saved_object_tagging/functional/tests/bulk_assign·ts - saved objects tagging - functional tests bulk assign "after each" hook for "can bulk assign tags to objects"
6 participants
@pgayvallet @kibana-ci @elasticmachine @spalger @rudolf @kibanamachine