Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 open API spec for ml sync #136234

Merged
merged 11 commits into from
Jul 21, 2022
Merged

Add v2 open API spec for ml sync #136234

merged 11 commits into from
Jul 21, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jul 12, 2022

Summary

This PR adds missing summary properties to the open API v3 specifications for the machine learning sync API. It also adds a v2 version of the specification, for generating documentation (used in #136583)

@lcawl lcawl marked this pull request as ready for review July 19, 2022 18:26
@lcawl lcawl requested a review from a team as a code owner July 19, 2022 18:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v8.3.3 labels Jul 19, 2022
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of questions which are more to do with the preview that is being generated for #136583

x-pack/plugins/ml/common/openapi/ml_apis_v2.json Outdated Show resolved Hide resolved
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit b177ad9 into elastic:main Jul 21, 2022
@lcawl lcawl deleted the sync-v2 branch July 21, 2022 19:05
kibanamachine pushed a commit that referenced this pull request Jul 21, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Jul 21, 2022
(cherry picked from commit b177ad9)

Co-authored-by: Lisa Cawley <lcawley@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed docs :ml release_note:skip Skip the PR/issue when compiling release notes v8.3.3 v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants