-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small clean up with visualize test + extra debug log #13755
Small clean up with visualize test + extra debug log #13755
Conversation
First run passed the test in question, though failed at the end due to an s3 upload error. So for our intents, it counts as a pass:
Not that I did anything to actually fix it, but am curious to see how the output looks during a failure and how flaky this test is. Jenkins, test this. |
Second time passed. Jenkins, test this. |
Passed a third time. cc @timroes -- any idea how often I should be seeing this error? I doubt my slight changes fixed it. I could perhaps check this in since it's just a small clean up, and then the next time we'll run into it I'll at least have a little extra debug out. Jenkins test this. |
another failure for s3, but a pass for the jenkins, test this |
Unit test failures this time:
Not much information as to where they are coming from. Though not the test I am investigating. This last run is a no-op. Will sync with master to see if I need some changes. |
906e73a
to
95db986
Compare
Passed 5 times. Lets get this checked in and if any more errors occur I'll take another look. There were two toast message statements in a row and I wanted to see which one was failing. Hopefully the added debug line will help when it hits again. To be clear, I don't believe I fixed the bug, but perhaps changing the code slightly altered the timing and made it hard to reproduce. |
Investigate and fix #13754