Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove junk tests #14191

Merged
merged 1 commit into from
Oct 4, 2017
Merged

remove junk tests #14191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core_plugins/spy_modes/public/table_spy_mode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'ui/agg_table';
// import 'ui/agg_table';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment this out instead of removing it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was an oversight, I'll clean that up.

import { AggResponseTabifyProvider } from 'ui/agg_response/tabify/tabify';
import tableSpyModeTemplate from 'plugins/spy_modes/table_spy_mode.html';
import { SpyModesRegistryProvider } from 'ui/registry/spy_modes';
Expand Down
4 changes: 0 additions & 4 deletions src/ui/public/agg_types/__tests__/buckets/date_histogram/_date_histogram.js
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions src/ui/public/agg_types/__tests__/buckets/date_histogram/_editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,31 +97,5 @@ describe('editor', function () {
});
});

describe('interval "auto" and indexPattern timeField', function () {
let params;

beforeEach(function () {
params = render({ field: indexPattern.timeFieldName, interval: 'auto' });
});

it('clears the interval when the field is changed', function () {
expect(params.interval.modelValue().val).to.be('auto');
expect(params.field.modelValue().name).to.be(indexPattern.timeFieldName);

const field = _.find(indexPattern.fields, function (f) {
return f.type === 'date' && f.name !== indexPattern.timeFieldName;
});

params.field.$input()
.find('option')
.filter(function () {
return $(this).text().trim() === field.name;
})
.prop('selected', true);
params.field.$input().change();

expect(params.interval.modelValue()).to.be(undefined);
});
});

});
2 changes: 2 additions & 0 deletions src/ui/public/agg_types/__tests__/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import './agg_params';
import './buckets/_histogram';
import './buckets/_geo_hash';
import './buckets/_range';
import './buckets/date_histogram/_editor';
import './buckets/date_histogram/_params';
import { AggTypesIndexProvider } from 'ui/agg_types/index';
import { AggTypesBucketsBucketAggTypeProvider } from 'ui/agg_types/buckets/_bucket_agg_type';
import { AggTypesMetricsMetricAggTypeProvider } from 'ui/agg_types/metrics/metric_agg_type';
Expand Down